Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a progress bar #144

Closed
wants to merge 1 commit into from
Closed

Conversation

tjgalvin
Copy link
Contributor

@tjgalvin tjgalvin commented May 5, 2021

As a quick proof of concept, I added a quick progress bar to provide some indication on the state of aegean as it is fitting. It is fairly straightword using tqdm. An option has been added to either enable or disable this progress bar from appearing. At the moment it is not writing to the logger object -- rather it is just printing to stdout. I am not sure what you would prefer here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 82.635% when pulling 0493544 on tjgalvin:progressbar into 174c059 on PaulHancock:main.

@PaulHancock
Copy link
Owner

as a proof of concept I like this a lot. Due to the way that I do the fitting (and re-fitting) within Aegean there are annoying things that need to be addressed before we can have this as a completed solution:

  • need to have the progress bar working in the priorized fitting as well as normal fitting routines
  • I did some not so smart things when doing a single core fit that kind of break the progress bar as implemented. Eg, when a single core is used this progress bar jumps 0->100% in one step in an instant.

These are both fixable things, and your tqdm solution is a good template for incorporating them.

PaulHancock added a commit that referenced this pull request May 11, 2021
PaulHancock added a commit that referenced this pull request May 11, 2021
@PaulHancock
Copy link
Owner

Your ideas have been incorporated into a different pull request so this one is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants