Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught island param estimate exception #151

Closed
wants to merge 9 commits into from

Conversation

tjgalvin
Copy link
Contributor

@tjgalvin tjgalvin commented Sep 6, 2021

I found a strange case where lmfit.params was throwing an error in the minimum and maximum limits of the amplitude parameter being the same. As far as I can tell from the logs and manual inspection it is not the case. In any case, I added an extra try / except. But I don't exactly like this solution, as it is hiding what is going on. I leave this here for the moment as it does seem to fix the failure case I am seeing.

Sorry for the horrible string of commits in this request. I done goofed.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 82.386% when pulling 2693141 on tjgalvin:master into 11e8912 on PaulHancock:main.

@tjgalvin
Copy link
Contributor Author

This should be killed and ignored.

@tjgalvin tjgalvin closed this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants