Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad url search keyword encoding #117

Closed
PaulMcInnis opened this issue Oct 15, 2020 · 3 comments
Closed

Bad url search keyword encoding #117

PaulMcInnis opened this issue Oct 15, 2020 · 3 comments
Labels
Milestone

Comments

@PaulMcInnis
Copy link
Owner

Description

We currently pass keywords verbatim, even if they include “+” or other special characters, we should be encoding these so as not to disrupt the url formation.

Steps to Reproduce

  1. Search with any word containing +s such as “C++”

Expected behavior

We would get a query containing “%” encoded values in place of +s

Actual behavior

We build a search string with erroneous + chars that breaks the search query url (query is not as intended)

Environment

  • Build: current dev
  • Operating system Ubuntu 18.04
@PaulMcInnis PaulMcInnis added this to the 3.0.2 milestone Oct 15, 2020
@PaulMcInnis
Copy link
Owner Author

We should consider using a library that construct urls for us which handles encoding

@markkvdb
Copy link
Collaborator

This problem is supposed to be fixed in #114

@PaulMcInnis
Copy link
Owner Author

Marking duplicate #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants