Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time.h conflicts with time.h on case sensitive filesystems #74

Closed
sandeepmistry opened this issue May 10, 2017 · 6 comments
Closed

Time.h conflicts with time.h on case sensitive filesystems #74

sandeepmistry opened this issue May 10, 2017 · 6 comments

Comments

@sandeepmistry
Copy link

Hi @PaulStoffregen,

Some Arduino users are trying to use this library with libraries like RTCZero that #include <time.h> on case sensitive filesystems like macOS and older Windows. Here's a related issue: arduino-libraries/RTCZero#28

The compiler ends up including Time.h instead of the POSIX <time.h> inside the RTCZero library which causes compile errors. Would you be open to renaming Time.h in the library to avoid conflicts?

@PaulStoffregen
Copy link
Owner

#32

#39

@PaulStoffregen
Copy link
Owner

TL;DR = already fixed. Include TimeLib.h, and don't use very old copies of this lib. Simple.

@PaulStoffregen
Copy link
Owner

Ideally, find whatever old wiki or other web pages these users are seeing and update them!

@sandeepmistry
Copy link
Author

Well, maybe I should propose removing "Time.h" from this repo instead.

As soon as a sketch include "TimeLib.h", the "Time.h" file in this repo will in the header search path and conflict with the POSIX "time.h" includes.

@PaulStoffregen
Copy link
Owner

This library aims to preserve compatibility with older versions of Arduino.

@Niek
Copy link

Niek commented Nov 8, 2019

I agree with @sandeepmistry - removing the Time.h file (in at least the git version) would be the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants