For single-file audiobooks prefer the title over the album for the book name #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2024
balki
reviewed
Jan 20, 2024
| name = migrationMetaData?.name ?: analyzed?.bookName ?: analyzed?.chapterName ?: file.bookName(), | ||
| name = buildList { | ||
| add(migrationMetaData?.name) | ||
| if (chapters.size == 1) { |
There was a problem hiding this comment.
Does chapters.size == 1 mean single file book? I see in some podcast episode mp3s, there are multiple chapters embedded in a single mp3. Those should also have title as the book name or may be '{album} - {tittle}'.
There was a problem hiding this comment.
Suggested change
| if (chapters.size == 1) { | |
| if (!file.isDirectory) { |
There was a problem hiding this comment.
One chapter = one file already. Every chapter itself can contain chapter marks.
It's not the best naming currently
There was a problem hiding this comment.
I see. Thanks for clarifying! Looking forward for the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2253 #2171 #2228 #2025