Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use title tag as book name #2253

Closed
wants to merge 1 commit into from

Conversation

FineFindus
Copy link
Contributor

Fixes an issue where the album tag was displayed instead of the title. This can be an issue with audio files that are part of a larger series, where the album is set to the series title instead of the episode title.

Before After
Listitem showing 'Auphonic Examples' as the title Listitem showing 'Auphonic Chapter Marks Demo' as the title

For example, Amberol correctly uses the title tag.
Audio file in Amberol with correct title

Closes #2171

I was wondering what chapterName actually does. I couldn't find any use for it in the UI.

@PaulWoitaschek
Copy link
Owner

But let's say you have an audiobook like Harry Potter 1.
The album is "Harry Potter 1". The first file is being used and it's title is "Chapter 1 - The Boy Who Lived".
Now instead of "Harry Potter 1" this would show up as "Chapter 1 - The Boy Who Lived".

I'm unsure what a good approach would be here? I'd assume that for most of the cases this change would make it worse.

@PaulWoitaschek
Copy link
Owner

Could you check this one?

#2261

Should bring the best of both worlds.

@FineFindus
Copy link
Contributor Author

Hmm, I completely overlooked the use case of having chapters as individual audio files, since I always use embedded chapters. I tested #2261 and it works, great idea. So I'm closing this one in favor of it :)

@FineFindus FineFindus closed this Jan 19, 2024
@PaulWoitaschek
Copy link
Owner

Yep, it's quite complicated to do stuff with the various types of use cases in mind and not breaking use cases 🤷

@FineFindus FineFindus deleted the fix/title-album branch January 19, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podcast titles are all the same
2 participants