WIP - Remove globals, allow multiple network constants.

[belovachap]

@peerchemist @saeveritt (+ others)

Here's a pass at removing globals/setup from the btcpy library. It introduces Network Constants and uses object inheritance to allow for a more flexible library :) Also, the unit tests are passing again (but I probably broke the integration ones :p).

[peerchemist]

Will this alllow for using constants namedtuples from the pypeerassets library?

[belovachap]

I'll probably try integrating this experimental branch with pypeerassets tomorrow. I suppose as long as the namedtuples in pypeerassets support the same fields as the btcpy Constants we could pass them into the library and they'd work.

I was imagining importing the Constants provided by btcpy and using them as givens in project code. But that will probably become clearer (even for me ;)) once I work out the experimental integration of the experimental branch :)

[peerchemist]

We'll have to do the normalization of the properties find in pypeerassets.networks and btcpy.constants. Naturally pypeerassets one will feature more information, but that wont mind the btcpy.

Why I want to make btcpy use params from pypeerassets is so we can only keep updating the list of supported networks at one place - pypeerassets.

[peerchemist]

This line should be: decimals=Decimal('1e8')

[peerchemist]

@belovachap this is very good work. Very hard to review due to large amount of changes, but you got around the differences between Peercoin and Bitcoin transaction format too, bravo.
However, it's quite invasive and it pushed this branch quite far from the upstream. We do want to keep close with them so we change the costs of maintenance and maintain the readiness of easily accepting their improvements.

So, I propose that this massive PR is broken into several pieces:

1. Usage of NamedTuple in the constants.py over the dict.
2. Removal of the setup.py in the workflow.

Then merge in 1 and 2 in our branch, and PR it to the upstream. If they accept this we'll keep quite close.

3. Merge in the BitcoinTransaction and PeercoinTransaction change, with note that PeercoinTransaction is temporary and we should not base long term strategy on it, as Peercoin is close to dropping the transaction timestamp and adopting the Segwit.

[belovachap]

Breaking it up into those chunks makes enough sense to me 👍 I'll make some new branches / pull requests 🌈

[belovachap]

These changes were broken down and committed to master in pieces :) Closing this pull request.