This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Start using experimental btcpy. #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peerchemist
reviewed
Jun 11, 2018
| @@ -4,6 +4,7 @@ | |||
| from math import ceil | |||
| from time import time | |||
|
|
|||
| from btcpy.constants import Constants | |||
There was a problem hiding this comment.
linter reports that this import is not used.
There was a problem hiding this comment.
i'll double check it, i bet the linter is right :)
what linter/command do you run? i should probably use it too
|
@belovachap do we close this one? |
|
Yeah, let's close this pull request (along with PeerAssets/btcpy#6) and pick up over in #121 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peerchemist @saeveritt
Here's a pass at using the experimental btcpy ( PeerAssets/btcpy#6 ) with pypeerassets. Some more of our tests pass now that btcpy can operate on different network constants :)