Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Beta Release #2

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Initial Beta Release #2

wants to merge 5 commits into from

Conversation

PenguinzPlays
Copy link

Initial Rock image

@guardrails
Copy link

guardrails bot commented Mar 26, 2023

⚠️ We detected 2 security issues in this pull request:

Hard-Coded Secrets (2)
Docs Details
💡 Title: Secret Keyword, Severity: Medium
ARG MAAS_ADMIN_PASSWORD="ChangeMeNow!"
💡 Title: Secret Keyword, Severity: Medium

rock/.env

Line 2 in 4ad6cca

MAAS_ADMIN_PASSWORD="ChangeMeNow!"

More info on how to fix Hard-Coded Secrets in General.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@PenguinzPlays PenguinzPlays added this to the MVP milestone Mar 26, 2023
Copy link

@ThisIsTeoRawr ThisIsTeoRawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing in the docker compose except the templates stuff
The code in the build.yml file is jumbled together I will put those tasks in separate files
There are no tests in the test.yml file
All the processes are jumbled into the run.yml file I would put the processes in separate files and space it out it makes
debugging easier
Line 7 until 9 must be removed in the entrypoint.yml file

@PenguinzPlays
Copy link
Author

This is only necessary if there is a large number of these, since this one is fairly basic, it is fine to keep in one file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants