Do some things. #6051
Merged
Do some things. #6051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing it to empty if we don't want to show it instead of requiring a separate boolean. 2. Reverse the polarity of do_not_hide_active_runs making it hide_active_runs to avoid double negatives. 3. Move the code that understands how to remove active runs from a list of decks and set the corresponding active_runs_text into a shared place on View so that we can call it on things other than self.decks. (It's possible that this does not go far enough and it should be possible to call prepare_decks on anything at all, or that this should happen automatically to every object in a given member variable, and/or that this should be applied to all the prepare_Xs methods, but that's for another day.) 4. Call the newly shared code from PersonAchievements for each deck table in the page. Fixes #6031.
It's probably a good thing.
vorpal-buildbot
added
Pending-on-LOGS
|
Seen on LOGS, PROD (created by @bakert and merged by @vorpal-buildbot 1 minute ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.