Add output if a successful authentication is via Guest privileges #333
Conversation
Marshall-Hallenbeck
requested review from
zblurx,
NeffIsBack and
mpgn
as code owners
|
Love it ahah! Yeah I see no reason why hashes could be anything except 16/32 :) |
|
yeah nice :) |
|
Did not test that, but shouldn't |
|
On that note, @Marshall-Hallenbeck can you add tests for a file containing hashes, including a test where we use the full |
|
Somehow github doesn't show the latest tests anymore, but after mpgn approval the tests failed for py3.8 @Marshall-Hallenbeck ref: https://github.com/Pennyw0rth/NetExec/actions/runs/9384835180 |
|
@NeffIsBack uhh weird, that is a package error, and I didn't change anything about the packages. |
… the colon between NTLM hashes
|
Rerun the tests and they are looking fine now. Though, for py3.8 the Threadpool has some weird error, looks like #330 ref: https://github.com/Pennyw0rth/NetExec/actions/runs/9384835180/job/25851429136 |
|
Oh, @Marshall-Hallenbeck you did add a hash file but not a test using it, did you? |
|
@NeffIsBack oop yeah you're right, I'll add 'em and PR real quick |
@Dfte wrote a great post about Guest vs NULL sessions here, so I have updated the SMB plaintext&hash login code to tell the user if the login was via Guest privileges.
Hopefully this along with the blog post helps alleviate confusion!
@mpgn @NeffIsBack I added code to check if the hash is 16 or 32 bytes, do you think it's necessary? Helps catch if people off-by-one the length of hashes. There's no reason the hash should be anything else, right?