-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with an ESM build of React #1
Comments
Good catch, haven't actually tried out the unofficial ESM versions. Will give it a look when I can. Do you have an example on how the React package is used? |
Actually, should be a drop-in replacement for the CJS builds. And it is, for the most part, but the plugin does not work. |
I pushed an example of it working here: https://github.com/PepsRyuu/rollup-plugin-react-refresh/tree/master/example-esm The thing that gets it working is Let me know if this solves it for you! :) |
Development and build configurations tested, it's working fine. Jest breaks with ESM modules of React, but that's not relevant here. Closing, thanks. |
Hello, I'm not really sure if this is the issue of the plugin, but the plugin does not work if I use pikapkg build of React, refresh functionality stops working. I'd really love to remove commonjs from the plugin chain, so if you have any idea what could the issue be, I'd really appreciate it.
OT, great job on the nollup and the article on Rollup and Webpack. I was able to run a typescript build with minor tweaks and have everything working almost OOTB with your example. I'll have to try it a bit more, but I'm suprised how little time I spent on configuring the bundler. Thanks.
The text was updated successfully, but these errors were encountered: