Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wl,-rpath not supported on Mac OS X 10.4 #410

Open
evanmiller opened this issue Dec 29, 2021 · 4 comments
Open

-Wl,-rpath not supported on Mac OS X 10.4 #410

evanmiller opened this issue Dec 29, 2021 · 4 comments

Comments

@evanmiller
Copy link

#403 has broken Makefile generation on Mac OS X 10.4 and earlier, whose linkers do not support -rpath. A proposed patch can be found here (taken from macports/macports-ports#13529):

https://raw.githubusercontent.com/macports/macports-ports/8ea194cdc747dfb772b6f968d8e561da80440e58/perl/p5-extutils-makemaker/files/patch-extutils-makemaker-rpath.diff
@hakonhagland
Copy link
Contributor

@evanmiller Thanks for the report and patch!

@maintainers: I can create a pull request from the patch if needed? What is common practice with patches?

@Leont
Copy link
Member

Leont commented Dec 29, 2021

Yeah, a pull request is appreciated.

hakonhagland added a commit to hakonhagland/ExtUtils-MakeMaker that referenced this issue Dec 29, 2021
@hakonhagland
Don't use rpath for macOS <= 10.4
06fe284 
Mac OS X 10.4 and earlier do not support -rpath. Fixes issue Perl-Toolchain-Gang#410 by
including patch given in

macports/macports-ports#13529
@hakonhagland hakonhagland mentioned this issue Dec 29, 2021
Merged
@hakonhagland
Copy link
Contributor

@Leont Ok, I have added a PR, see #412

bingos pushed a commit that referenced this issue Jul 22, 2022
@hakonhagland @bingos
Don't use rpath for macOS <= 10.4
9b42512 
Mac OS X 10.4 and earlier do not support -rpath. Fixes issue #410 by
including patch given in

macports/macports-ports#13529
@sevan
Copy link

sevan commented Apr 18, 2023

The test suite also needs to be handled. I have a smoke test on Tiger in flight at the moment and I see

[2023-04-18 02:53:17-0400]     ../cpan/ExtUtils-MakeMaker/t/04-xs-rpath-darwin.t...........FAILED
[2023-04-18 02:53:17-0400]         Non-zero exit status: 255
[2023-04-18 02:53:17-0400]     ../cpan/ExtUtils-MakeMaker/t/04-xs-rpath-darwin.t...........FAILED
[2023-04-18 02:53:17-0400]         Bad plan.  You planned 1 tests but ran 0.

sevan added a commit to sevan/ExtUtils-MakeMaker that referenced this issue Apr 27, 2023
@sevan
t/04-xs-rpath-darwin.t: Need Darwin 9 minimum
d5488fc 
-rpath is not support on toolchain of older Darwin versions.
Fix for test part of issue Perl-Toolchain-Gang#410
@sevan sevan mentioned this issue Apr 27, 2023
Open
sevan added a commit to sevan/ExtUtils-MakeMaker that referenced this issue Apr 27, 2023
@sevan
t/04-xs-rpath-darwin.t: Need Darwin 9 minimum
ac29419 
-rpath is not support on toolchain of older Darwin versions.
Fix for test part of issue Perl-Toolchain-Gang#410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Leont @evanmiller @sevan @hakonhagland