p5-extutils-makemaker: fix Makefile generation on Tiger #13529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakonhagland
added a commit
to hakonhagland/ExtUtils-MakeMaker
that referenced
this pull request
Dec 29, 2021
Mac OS X 10.4 and earlier do not support -rpath. Fixes issue Perl-Toolchain-Gang#410 by including patch given in macports/macports-ports#13529
|
This change doesn't look MacPorts-specific. Have you proposed it to the developers? Can you include a URL to that proposal? |
|
Unmerged upstream PR is here Perl-Toolchain-Gang/ExtUtils-MakeMaker#412 |
bingos
pushed a commit
to Perl-Toolchain-Gang/ExtUtils-MakeMaker
that referenced
this pull request
Jul 22, 2022
Mac OS X 10.4 and earlier do not support -rpath. Fixes issue #410 by including patch given in macports/macports-ports#13529
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without this patch, ExtUtils::MakeMaker produces Makefiles that will not compile on Tiger. Tested by building
p5-locale-gettext, which will not build with unmodified MakeMaker.Type(s)
Tested on
macOS 10.4.11
Xcode x.y
Verification
Have you
port lint?sudo port test?sudo port -vst install?