BBC: Commit 7259f419 breaks PPI

[p5pRT]

Migrated from rt.perl.org#134210 (status was 'rejected')

Searchable as RT134210$

[p5pRT]

From @jkeenan

A commit somewhere between 5.31.0 and
84ab3b6 has broken a test in the test
suite for CPAN distribution PPI. The range is suggested by this
cpantesters matrix page​:

http​://matrix.cpantesters.org/?dist=PPI;perl=5.31.1;reports=1http​://matrix.cpantesters.org/?dist=PPI;perl=5.31.1;reports=1

The failures look like this​:

#####
t/07_token.t (Wstat​: 512 Tests​: 588 Failed​: 2)
  Failed tests​: 343, 383
  Non-zero exit status​: 2

ok 342 - '0b' not :​:Exp
not ok 343 - literal('0b'), syntax error at (eval 322) line 1, near "0b
# "
#
ok 344 - '0b0' is a single token

ok 382 - '0x' not :​:Exp
not ok 383 - literal('0x'), syntax error at (eval 353) line 1, at EOF
#
ok 384 - '0x0' is a single token
#####

See, for example,
http​://www.cpantesters.org/cpan/report/1ca39640-8fe4-11e9-a494-7754e9c36978

I haven't managed to bisect this yet, but since PPI has many, many
dependencies, this is going to cause a lot of installation failures when
we start to test the CPAN-river-3000 against perl-5.31.1 later this week.

The perl_V attachment is not directly relevant to this report.

Thank you very much.
Jim Keenan

[p5pRT]

From @jkeenan

Summary of my perl5 (revision 5 version 29 subversion 10) configuration​:
  Commit id​: 06cbc31
  Platform​:
  osname=linux
  osvers=4.15.0-47-generic
  archname=x86_64-linux
  uname='linux zareason 4.15.0-47-generic #50-ubuntu smp wed mar 13 10​:44​:52 utc 2019 x86_64 x86_64 x86_64 gnulinux '
  config_args='-des -Dusedevel -Uversiononly -Dprefix=/home/jkeenan/testing/blead -Dman1dir=none -Dman3dir=none'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
  optimize='-O2'
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='7.3.0'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/7/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /lib64 /usr/lib64
  libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.27.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.27'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_PERLIO
  USE_PERL_ATOF
  Built under linux
  Compiled at Apr 3 2019 07​:41​:43
  %ENV​:
  PERL2DIR="/home/jkeenan/gitwork/perl2"
  PERLBREW_HOME="/home/jkeenan/.perlbrew"
  PERLBREW_MANPATH="/home/jkeenan/perl5/perlbrew/perls/perl-5.28.0/man"
  PERLBREW_PATH="/home/jkeenan/perl5/perlbrew/bin​:/home/jkeenan/perl5/perlbrew/perls/perl-5.28.0/bin"
  PERLBREW_PERL="perl-5.28.0"
  PERLBREW_ROOT="/home/jkeenan/perl5/perlbrew"
  PERLBREW_SHELLRC_VERSION="0.84"
  PERLBREW_VERSION="0.84"
  PERL_WORKDIR="/home/jkeenan/gitwork/perl"
  @​INC​:
  lib
  /home/jkeenan/testing/blead/lib/perl5/site_perl/5.29.10/x86_64-linux
  /home/jkeenan/testing/blead/lib/perl5/site_perl/5.29.10
  /home/jkeenan/testing/blead/lib/perl5/5.29.10/x86_64-linux
  /home/jkeenan/testing/blead/lib/perl5/5.29.10

[p5pRT]

From @tonycoz

On Tue, 18 Jun 2019 14​:41​:37 -0700, jkeenan@​pobox.com wrote​:

A commit somewhere between 5.31.0 and
84ab3b6 has broken a test in the test
suite for CPAN distribution PPI. The range is suggested by this
cpantesters matrix page​:

http​://matrix.cpantesters.org/?dist=PPI;perl=5.31.1;reports=1http​://matrix.cpantesters.org/?dist=PPI;perl=5.31.1;reports=1

The failures look like this​:

#####
t/07_token.t (Wstat​: 512 Tests​: 588 Failed​: 2)
Failed tests​: 343, 383
Non-zero exit status​: 2

ok 342 - '0b' not :​:Exp
not ok 343 - literal('0b'), syntax error at (eval 322) line 1, near
"0b
# "
#
ok 344 - '0b0' is a single token

ok 382 - '0x' not :​:Exp
not ok 383 - literal('0x'), syntax error at (eval 353) line 1, at EOF
#
ok 384 - '0x0' is a single token
#####

See, for example,
http​://www.cpantesters.org/cpan/report/1ca39640-8fe4-11e9-a494-
7754e9c36978

I haven't managed to bisect this yet, but since PPI has many, many
dependencies, this is going to cause a lot of installation failures
when
we start to test the CPAN-river-3000 against perl-5.31.1 later this
week.

The perl_V attachment is not directly relevant to this report.

Going by the error it's likely from​:

commit 7259f41
Author​: Tony Cook <tony@​develop-help.com>
Date​: Tue Jun 4 16​:35​:35 2019 +1000

  (perl #134125) accept only complete hex and binary literals

which changes the way code like​:

$x = 0x;

is parsed.

Previously the "0x" was parsed as a hex constant with value 0, but without the following digits it's now parsed as a constant 0 followed by an x operator.

Another option would be to treat such incomplete hex/binary constants as errors, but PPI would still be failing.

I think it's something PPI will need to fix.

Tony

[p5pRT]

The RT System itself - Status changed from 'new' to 'open'

[p5pRT]

From @jkeenan

On Wed, 19 Jun 2019 00​:20​:04 GMT, tonyc wrote​:

On Tue, 18 Jun 2019 14​:41​:37 -0700, jkeenan@​pobox.com wrote​:

A commit somewhere between 5.31.0 and
84ab3b6 has broken a test in the
test
suite for CPAN distribution PPI. The range is suggested by this
cpantesters matrix page​:

http​://matrix.cpantesters.org/?dist=PPI;perl=5.31.1;reports=1http​://matrix.cpantesters.org/?dist=PPI;perl=5.31.1;reports=1

The failures look like this​:

#####
t/07_token.t (Wstat​: 512 Tests​: 588 Failed​: 2)
Failed tests​: 343, 383
Non-zero exit status​: 2

ok 342 - '0b' not :​:Exp
not ok 343 - literal('0b'), syntax error at (eval 322) line 1, near
"0b
# "
#
ok 344 - '0b0' is a single token

ok 382 - '0x' not :​:Exp
not ok 383 - literal('0x'), syntax error at (eval 353) line 1, at EOF
#
ok 384 - '0x0' is a single token
#####

See, for example,
http​://www.cpantesters.org/cpan/report/1ca39640-8fe4-11e9-a494-
7754e9c36978

I haven't managed to bisect this yet, but since PPI has many, many
dependencies, this is going to cause a lot of installation failures
when
we start to test the CPAN-river-3000 against perl-5.31.1 later this
week.

The perl_V attachment is not directly relevant to this report.

Going by the error it's likely from​:

commit 7259f41
Author​: Tony Cook <tony@​develop-help.com>
Date​: Tue Jun 4 16​:35​:35 2019 +1000

(perl #134125) accept only complete hex and binary literals

which changes the way code like​:

$x = 0x;

is parsed.

Previously the "0x" was parsed as a hex constant with value 0, but
without the following digits it's now parsed as a constant 0 followed
by an x operator.

Another option would be to treat such incomplete hex/binary constants
as errors, but PPI would still be failing.

I think it's something PPI will need to fix.

Yes, that's the commit. Tail of output from this command​:

#####
perl Porting/bisect.pl --start=v5.31.0 --end=84ab3b690861c92bea535c991537bdde20c93750 --module=PPI
#####

#####
7259f41 is the first bad commit
commit 7259f41
Author​: Tony Cook <tony@​develop-help.com>
Date​: Tue Jun 4 16​:35​:35 2019 +1000

  (perl #134125) accept only complete hex and binary literals

:040000 040000 9bf22887767492c8d5b85e10d7338eb182ebfd0b f1160792ee57d5d96f2b5374c78fdde7fc3cd43e M t
:100644 100644 dba907d8570316acab70f8a048673d4f6e39bd07 26d383f0065260c926a736e24084b21dfa5c853a M toke.c
bisect run success
That took 2129 seconds.
#####

--
James E Keenan (jkeenan@​cpan.org)

[p5pRT]

From @jkeenan

On Wed, 19 Jun 2019 00​:20​:04 GMT, tonyc wrote​:

On Tue, 18 Jun 2019 14​:41​:37 -0700, jkeenan@​pobox.com wrote​:

A commit somewhere between 5.31.0 and
84ab3b6 has broken a test in the
test
suite for CPAN distribution PPI. The range is suggested by this
cpantesters matrix page​:

http​://matrix.cpantesters.org/?dist=PPI;perl=5.31.1;reports=1http​://matrix.cpantesters.org/?dist=PPI;perl=5.31.1;reports=1

The failures look like this​:

#####
t/07_token.t (Wstat​: 512 Tests​: 588 Failed​: 2)
Failed tests​: 343, 383
Non-zero exit status​: 2

ok 342 - '0b' not :​:Exp
not ok 343 - literal('0b'), syntax error at (eval 322) line 1, near
"0b
# "
#
ok 344 - '0b0' is a single token

ok 382 - '0x' not :​:Exp
not ok 383 - literal('0x'), syntax error at (eval 353) line 1, at EOF
#
ok 384 - '0x0' is a single token
#####

See, for example,
http​://www.cpantesters.org/cpan/report/1ca39640-8fe4-11e9-a494-
7754e9c36978

I haven't managed to bisect this yet, but since PPI has many, many
dependencies, this is going to cause a lot of installation failures
when
we start to test the CPAN-river-3000 against perl-5.31.1 later this
week.

The perl_V attachment is not directly relevant to this report.

Going by the error it's likely from​:

commit 7259f41
Author​: Tony Cook <tony@​develop-help.com>
Date​: Tue Jun 4 16​:35​:35 2019 +1000

(perl #134125) accept only complete hex and binary literals

which changes the way code like​:

$x = 0x;

is parsed.

Previously the "0x" was parsed as a hex constant with value 0, but
without the following digits it's now parsed as a constant 0 followed
by an x operator.

Another option would be to treat such incomplete hex/binary constants
as errors, but PPI would still be failing.

I think it's something PPI will need to fix.

Tony

I have created this issue​:

Perl-Critic/PPI#245

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

[p5pRT]

From @tonycoz

On Wed, 19 Jun 2019 11​:11​:35 -0700, jkeenan wrote​:

On Wed, 19 Jun 2019 00​:20​:04 GMT, tonyc wrote​:

On Tue, 18 Jun 2019 14​:41​:37 -0700, jkeenan@​pobox.com wrote​:

A commit somewhere between 5.31.0 and
84ab3b6 has broken a test in the
test
suite for CPAN distribution PPI. The range is suggested by this
cpantesters matrix page​:

http​://matrix.cpantesters.org/?dist=PPI;perl=5.31.1;reports=1http​://matrix.cpantesters.org/?dist=PPI;perl=5.31.1;reports=1

The failures look like this​:

#####
t/07_token.t (Wstat​: 512 Tests​: 588 Failed​: 2)
Failed tests​: 343, 383
Non-zero exit status​: 2

ok 342 - '0b' not :​:Exp
not ok 343 - literal('0b'), syntax error at (eval 322) line 1, near
"0b
# "
#
ok 344 - '0b0' is a single token

ok 382 - '0x' not :​:Exp
not ok 383 - literal('0x'), syntax error at (eval 353) line 1, at
EOF
#
ok 384 - '0x0' is a single token
#####

See, for example,
http​://www.cpantesters.org/cpan/report/1ca39640-8fe4-11e9-a494-
7754e9c36978

I haven't managed to bisect this yet, but since PPI has many, many
dependencies, this is going to cause a lot of installation failures
when
we start to test the CPAN-river-3000 against perl-5.31.1 later this
week.

The perl_V attachment is not directly relevant to this report.

Going by the error it's likely from​:

commit 7259f41
Author​: Tony Cook <tony@​develop-help.com>
Date​: Tue Jun 4 16​:35​:35 2019 +1000

(perl #134125) accept only complete hex and binary literals

which changes the way code like​:

$x = 0x;

is parsed.

Previously the "0x" was parsed as a hex constant with value 0, but
without the following digits it's now parsed as a constant 0 followed
by an x operator.

Another option would be to treat such incomplete hex/binary constants
as errors, but PPI would still be failing.

I think it's something PPI will need to fix.

Tony

I have created this issue​:

Perl-Critic/PPI#245

Thank you very much.

Fixed in PPI 1.270.

Tony

[p5pRT]

@tonycoz - Status changed from 'open' to 'rejected'