Skip to content

Pr/send file mime : Support send_file("file", content_type => "png") #405

Closed
wants to merge 23 commits into from

7 participants

@ambs
PerlDancer member
ambs commented Mar 18, 2011

As discussed in IRC with bigpresh. Lets the user force a content_type programatically

@xsawyerx
PerlDancer member

+= 10 !

schwern and others added some commits Mar 16, 2011
@schwern schwern Fix the cookbook docs on using the Debug Plack middleware.
Signed-off-by: Michael G. Schwern <schwern@pobox.com>
f25fe8d
franck cuny changes 6883a81
franck cuny Merge branch 'review/schwern' into devel
* review/schwern:
  changes
  Fix the cookbook docs on using the Debug Plack middleware.
fc8949f
@schwern schwern Allow the session_name to be usefully changed during processing.
It was checked at load time in Dancer::Session::Abstract and then never again.

This allows one to maintain sessions for multiple sites in one Dancer process.
a54ebb0
@dams dams reflect changes 17ca5d7
@dams dams Merge branch 'review/schwern_session_name' into devel fb9a051
@yanick yanick first argument of tests can be a string
... in which case, the method is assumed to be GET
0fc95f1
@yanick yanick add documentation 9e4c808
@yanick yanick update CHANGES 616e965
franck cuny update CHANGES
Signed-off-by: franck cuny <franck@lumberjaph.net>
31803e1
franck cuny Merge branch 'review/yannick' into devel
* review/yannick:
  update CHANGES
  update CHANGES
  add documentation
  first argument of tests can be a string
c6a72ae
@racke racke Extend the POD on plugin_setting to prevent a pitfall with plugin mod…
…ules more than 3 levels deep.
bd94fc1
franck cuny add bold to POD; reflect changes
Signed-off-by: franck cuny <franck@lumberjaph.net>
17e569b
franck cuny Merge branch 'review/yannick' into devel
* review/yannick:
  update CHANGES
  update CHANGES
  add documentation
  first argument of tests can be a string

Conflicts:
	CHANGES

Signed-off-by: franck cuny <franck@lumberjaph.net>
9bfa46e
franck cuny Merge branch 'review/racke' into devel
* review/racke:
  add bold to POD; reflect changes
  Extend the POD on plugin_setting to prevent a pitfall with plugin modules more than 3 levels deep.
e966b60
@ambs ambs support content_type in send_file d82b98f
@sukria
PerlDancer member
sukria commented Mar 18, 2011

approved for the PR, but it appears it has not been done as described in Dancer::Development, because you have based your PR on the master branch, whereas it should be based on our "devel".

This is done via the GitHub web interface when you create the PR. Can you redo it please? :)

Thanks!

@sukria
PerlDancer member
sukria commented Mar 18, 2011

I close this one ;)

@sukria sukria closed this Mar 18, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.