Pr/send file mime : Support send_file("file", content_type => "png") #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stalled. (note: DSC IS broken, so don't merge this until it's fixed)
… Other minor things
Signed-off-by: Michael G. Schwern <schwern@pobox.com>
* review/schwern: changes Fix the cookbook docs on using the Debug Plack middleware.
It was checked at load time in Dancer::Session::Abstract and then never again. This allows one to maintain sessions for multiple sites in one Dancer process.
... in which case, the method is assumed to be GET
Signed-off-by: franck cuny <franck@lumberjaph.net>
* review/yannick: update CHANGES update CHANGES add documentation first argument of tests can be a string
…ules more than 3 levels deep.
Signed-off-by: franck cuny <franck@lumberjaph.net>
* review/yannick: update CHANGES update CHANGES add documentation first argument of tests can be a string Conflicts: CHANGES Signed-off-by: franck cuny <franck@lumberjaph.net>
* review/racke: add bold to POD; reflect changes Extend the POD on plugin_setting to prevent a pitfall with plugin modules more than 3 levels deep.
|
approved for the PR, but it appears it has not been done as described in Dancer::Development, because you have based your PR on the master branch, whereas it should be based on our "devel". This is done via the GitHub web interface when you create the PR. Can you redo it please? :) Thanks! |
|
I close this one ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in IRC with bigpresh. Lets the user force a content_type programatically