Feature/fileutils refactor cleanup

[ambs]

This is sawyer PR. Just making it public for better analysis, and not to forget.

[ambs]

Tested under mac OS X (Leopard) and Windows XP (Strawberry Perl). Both a sucess. "approved"

[xsawyerx]

Yay! Will test it on Windows again before merging.

[mokko]

How can I check it out to test it on cygwin? EDIT: Now I found it. Passes tests on cygwin. Code looks mighty clean!

[ambs]

git clone git://github.com/sukria/Dancer.git
git fetch origin 
git checkout feature/fileutils_refactor_cleanup

[mokko]

I don't know why I didn't see the branch feature/fileutils_refactor_cleanup at first. Maybe it didn't exist then or i was just blind. Anyways, Tests pass now on my cygwin. (It didn't do all the Test::TCP etc. tests.)

I wonder whether we still need path_no_verify. It still has a call to d_catdir and that is gone, right?

[ambs]

And if tests pass, then probably it is not used :P

[xsawyerx]

@mokko, I just added it a few days ago.

I'm happy all the tests pass on Cygwin! Thanks for testing it!
There is no path_no_verify() now. The regular path() function no longer verifies so it is the same as path_no_verify(), just MUCH faster and cleaner.

I added a wedge function that will be deprecated called path_or_empty() to return the path or empty string on non-existent paths. I'll deprecate it in the future in favor of checking if the path exists and then throwing an error if not.

It appears it passes all, so now we can collect approvals and merge it in.

@mokko, thanks again for your input on this entire subject!

[sukria]

approved! Thanks @xsawyerx for the great work!

[fcuny]

approved. I'm not sure why, but some commits are present more than once (some are presents 3 times)

[ambs]

merged. Thanks

[xsawyerx]

@franckcuny, I had issues rebasing it. Some really weird behavior... @sukria couldn't really help me understand it either. :)