Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: command sent is not an octet sequence in the native encoding - is croak the right way ? #149

Open
ReneBoehm opened this issue Oct 29, 2020 · 2 comments

Comments

@ReneBoehm
Copy link

Hi,

we are using this module in our projects and encountered this error a couple of times. The reason is clear to me but IMHO this should not result in a die but a return. Otherwise the whole process dies only because some data could not be cached. Maybe this behaviour should be configurable for those people who are using Redis as some kind of a database and not as a memory cache.

best regards
René

@dams
Copy link
Member

dams commented Oct 30, 2020

Hi,

returning and not dying would mean that the command is successful though, which would be misleading ? What return mechanism do you propose ?

@ReneBoehm
Copy link
Author

Maybe an empty (false) return would be sufficient. In this case the "client" can decide whether that's ok or not, in case it's just meant to be cached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants