-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instantiate native contract #596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvinwang
requested review from
shelvenzhou and
h4x3rotab
and removed request for
shelvenzhou
December 13, 2021 11:48
h4x3rotab
reviewed
Dec 13, 2021
kvinwang
force-pushed
the
instantiate-native
branch
from
December 14, 2021 02:44
61abf41
to
c0782c1
Compare
h4x3rotab
reviewed
Dec 17, 2021
kvinwang
force-pushed
the
instantiate-native
branch
from
December 23, 2021 06:24
204e513
to
1f598b2
Compare
shelvenzhou
force-pushed
the
pink-key-manage
branch
from
December 24, 2021 09:14
49836a5
to
c79a157
Compare
kvinwang
force-pushed
the
instantiate-native
branch
from
December 27, 2021 08:21
1f598b2
to
58cfa7d
Compare
kvinwang
force-pushed
the
instantiate-native
branch
from
December 29, 2021 03:10
58cfa7d
to
998d1a9
Compare
pink: Use customized ink address as contract id
9 tasks
kvinwang
force-pushed
the
instantiate-native
branch
from
January 10, 2022 02:56
3ea4155
to
7428dba
Compare
kvinwang
force-pushed
the
instantiate-native
branch
from
January 10, 2022 02:58
7428dba
to
4f446a9
Compare
h4x3rotab
reviewed
Jan 17, 2022
@@ -483,7 +488,34 @@ impl<Platform: pal::Platform> System<Platform> { | |||
contract.handle_query(origin, req, &mut context) | |||
} | |||
|
|||
pub fn process_messages(&mut self, block: &mut BlockInfo) -> anyhow::Result<()> { | |||
pub fn process_next_message(&mut self, block: &mut BlockInfo) -> anyhow::Result<bool> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the return value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loop {
match self.process_next_message(block) {
Err(err) => {
error!("Error processing message: {:?}", err);
}
Ok(no_more) => {
if no_more {
break;
}
}
}
}
h4x3rotab
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR implement native contract instantiation.