Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize array for php 7.2 compatibility #27

Merged
merged 1 commit into from
Apr 14, 2018

Conversation

LinkingYou
Copy link
Contributor

With PHP7.2 i get the following error:

Warning: count(): Parameter must be an array or an object that implements Countable

This fix repairs this issue.

Copy link

@mgrulich mgrulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is fine

@barryvdh
Copy link
Contributor

More than fine, it is required to run on php 7.2

Can this be merged?

@PhenX PhenX merged commit 798cadc into dompdf:master Apr 14, 2018
@barryvdh
Copy link
Contributor

Thank you, can you tag this as 0.3.1 also? Thanks!

@milose
Copy link

milose commented May 17, 2018

Can we tag this?

@hartono-sulaiman-kaskus

please, we need this tag

@RuubR
Copy link

RuubR commented Jun 1, 2018

Tag this please :)

@PhenX
Copy link
Member

PhenX commented Jun 2, 2018

Sorry guys for the long delay, I made the release, that should be good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants