feature: #10 Define claims order by entity type #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmformenti
changed the title
jmformenti
reviewed
Feb 20, 2024
frontend/components/ItemViewer.vue
Outdated
| try { | ||
| await this.$wikibase | ||
| .getEntity(this.id, this.$i18n.locale) | ||
| .then((entity) => { | ||
| this.item = entity | ||
| this.$store.commit('breadcrumb/setItems', this.getBreadcrumbItems(entity)); |
There was a problem hiding this comment.
Do we need to set breadcrumb elements here?
frontend/components/ItemViewer.vue
Outdated
| try { | ||
| await this.$wikibase | ||
| .getEntity(this.id, this.$i18n.locale) | ||
| .then((entity) => { | ||
| this.item = entity | ||
| this.$store.commit('breadcrumb/setItems', this.getBreadcrumbItems(entity)); | ||
| this.item = entity; |
There was a problem hiding this comment.
Please ensure you have eslint enabled, all these trailing commas introduced in this PR are not allowed
frontend/service/wikibase.service.js
Outdated
| @@ -279,24 +298,4 @@ export class WikibaseService { | |||
| } | |||
| return hash | |||
| } | |||
|
|
|||
| async searchEntityByName (search, language, uselang) { | |||
There was a problem hiding this comment.
Is it intended to eliminate this function? I see that it is even used here: https://github.com/PhiloBiblon/philobiblon-ui/blob/master/frontend/components/ValueViewer.vue#L155
jmformenti
force-pushed
the
claimissuesorting
branch
from
b10b698
to
0aa8e7c
Compare
jmformenti
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.