-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: #10 Define claims order by entity type #54
Conversation
frontend/components/ItemViewer.vue
Outdated
try { | ||
await this.$wikibase | ||
.getEntity(this.id, this.$i18n.locale) | ||
.then((entity) => { | ||
this.item = entity | ||
this.$store.commit('breadcrumb/setItems', this.getBreadcrumbItems(entity)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to set breadcrumb elements here?
frontend/components/ItemViewer.vue
Outdated
try { | ||
await this.$wikibase | ||
.getEntity(this.id, this.$i18n.locale) | ||
.then((entity) => { | ||
this.item = entity | ||
this.$store.commit('breadcrumb/setItems', this.getBreadcrumbItems(entity)); | ||
this.item = entity; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure you have eslint enabled, all these trailing commas introduced in this PR are not allowed
frontend/service/wikibase.service.js
Outdated
@@ -279,24 +298,4 @@ export class WikibaseService { | |||
} | |||
return hash | |||
} | |||
|
|||
async searchEntityByName (search, language, uselang) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intended to eliminate this function? I see that it is even used here: https://github.com/PhiloBiblon/philobiblon-ui/blob/master/frontend/components/ValueViewer.vue#L155
b10b698
to
0aa8e7c
Compare
No description provided.