Add Flatpak support #1406

plata · 2018-09-29T13:22:53Z

The manifest file is located in phoenicis-dist/src/flatpak.

Required extensions:

org.freedesktop.Platform.Compat.i386
org.freedesktop.Platform.GL32.nvidia-410-73 (or similar)

To build:

cd phoenicis-dist/src/flatpak/
flatpak-builder build-dir org.phoenicis.javafx.json --force-clean

Run with:

cd phoenicis-dist/src/flatpak/
flatpak-builder build-dir org.phoenicis.javafx.json --force-clean --user --install
flatpak run org.phoenicis.javafx phoenicis-javafx

fixes #1190

plata · 2018-09-29T13:29:30Z

@mbooth101 I'm installing OpenJFX 11 to use it with your OpenJDK 10 extension. It works but I think it would be nice to have an OpenJFX extension as well. Do you think that would be feasible?

madoar · 2018-10-05T14:15:30Z

In my opinion we should wait until a flatpak module for Java 11 exists.
Such a module has the big advantage, that we won't need a separate dependency to JavaFX 11, because it can be included in our application (jar-file) via maven.

plata · 2018-10-05T20:43:05Z

Would be nice, yes. Did you take a look at the JDK 10 extension? How hard can it be do adopt this for 11?
In any case the open issues of this pr (see description) must be solved.

madoar · 2018-10-05T21:37:25Z

Yes, I've taken a look at the JDK 10 extension at https://github.com/flathub/org.freedesktop.Sdk.Extension.openjdk10, which truth be told is quite hard to find on google.
I'm not sure how hard it is to adapt the script to JDK 11.
My problem with the extensions are that they look very hacky to me, where some commands are modified to work specifically with the given JDK version.
I'm not sure how transferable these commands are to JDK 11.

You're right, the most important open task is the open issue.
Could the problem be missing permissions for the sandbox?
For example to download wine?

plata · 2018-10-06T20:20:05Z

I assume that it's a permission issue as well. However, I've no idea what exactly the problem is.

phoenicis/phoenicis-dist/src/flatpak/org.phoenicis.javafx.json

Line 14 in 1abb8bb

"--filesystem=host",

should grant the required permissions (at least to my understanding). I've also tried the switch for permissions for home specifically, but that didn't help either. Phoenicis can read the exisiting library so it cannot be that it doesn't have rights at all. Downloading can also not be the issue because the required Wine version is installed already. Might be that execution permissions (for the Wine executable) require a special setting but I don't know what.

madoar · 2018-10-07T13:46:38Z

I may have found the source for the problem.
According to http://docs.flatpak.org/en/latest/sandbox-permissions.html, host blacklists the /tmp/ folder.
Isn't this the folder, where we download wine and other files?

plata · 2018-10-07T17:30:35Z

I think we have a tmp inside .Phoenicis but I have to check.

Maryse47 · 2018-10-08T17:30:38Z

flatpak-builder --run build-dir org.phoenicis.javafx.json phoenicis-javafx

flatpak-builder --run is known to be broken (it doesn't match flatpak environment correctly.

Use flatpak-builder --force-clean --install --user build-dir org.phoenicis.javafx.json instead then test with flatpak run org.phoenicis.javafx phoenicis-javafx.

plata · 2018-10-08T20:42:11Z

@Maryse47 I've noticed that there are differences already but even with the installed flatpak the issue remains.

mbooth101 · 2018-10-10T09:57:17Z

@mbooth101 I'm installing OpenJFX 11 to use it with your OpenJDK 10 extension. It works but I think it would be nice to have an OpenJFX extension as well. Do you think that would be feasible?

Hi @plata

Maybe -- I have no exposure to openjfx. How is it built?

BTW, there will be openjdk11 extension very soon: flathub/flathub#669

plata · 2018-10-10T17:00:52Z

@mbooth101 great! Looking forward to the OpenJDK 11 extension. I don't know how OpenJFX is built but if you look at my manifest in this PR, I'm just downloading and unpacking it which seems to be working (at least the GUI starts etc). I was thinking that it might be possible to do just that in an own extension for OpenJFX. Correct me if I'm wrong.

mbooth101 · 2018-10-10T17:06:02Z

I would just bare in mind that if it has native parts it may need to be built from source in order to support all the Flatpak architectures.

plata · 2018-10-10T17:23:15Z

They only have one Linux build on https://gluonhq.com/products/javafx/ so probably it's not that architecture dependent.

plata · 2018-10-11T19:26:54Z

I think my approach was wrong. Instead of accessing ~/.Phoenicis directly, the flatpak app should work in the sandbox. To achieve this, I set user.home to XDG_DATA_HOME (see https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html). However, the git checkout doesn't work now. This might be related to #1402 but opposed to that, deleting the cache and restarting doesn't solve the issue.

madoar · 2018-10-11T19:53:45Z

Did you receive an error message/exception?

plata · 2018-10-12T19:09:37Z

It said something about "<NAK". Not sure if that's an the error but I couldn't see anything else really (fetching the branches etc seemed to work ok). Can you give it a try? I think you know the git repository quite well.

plata · 2018-10-12T22:32:30Z

@LeandroStanger doesn't help, unfortunately.

madoar · 2018-10-13T07:56:39Z

@plata I'm not sure I can really help here.
I haven't used flatpak yet, so I'm not really sure how to use it correctly.
Does Phoenicis provide any kind of error message?

Out of interest, can a flatpak installation conflict with a deb installation?

plata · 2018-10-13T09:19:37Z

Description how to use it is in the pr description. It's sandboxed so it shouldn't conflict with the deb install.

plata · 2018-10-13T10:46:34Z

Strange. It worked now. I think it just took longer.

plata · 2018-10-13T10:59:00Z

Now I get:

java.lang.RuntimeException: java.io.IOException: Cannot run program "/home/plata/.var/app/org.phoenicis.javafx/data/.Phoenicis/engines//wine/upstream-linux-x86/3.0.3/bin/wine" (in directory "/home/plata/.var/app/org.phoenicis.javafx/data/.Phoenicis/containers/wineprefix/Notepad"): error=2, file not found

The file exists.

plata · 2018-10-20T14:59:16Z

I've tried to investigate the exception: it happens when luna tries to run regedit. However, the prefix exists so wineboot must have worked. I don't really understand what the difference should be between wine wineboot and wine regedit.

Maryse47 · 2018-10-21T10:59:40Z

I recommend to open PR in https://github.com/flathub/flathub/pulls . The most capable people to help are there.

plata · 2018-10-21T11:02:19Z

I've fixed the Wine 32bit issue. I could now successfully install and run Notepad++.

@Maryse47 the problem is that they only want stable versions (according to their docs). We're currently in alpha.

Maryse47 · 2018-10-21T12:24:29Z

You can mark it as WIP or something like that with the intention to not merge it before main app is stable. The goal is to get more help.

plata · 2018-10-21T12:25:46Z

I get your point. I'm just not sure that I need support currently because it seems to be working now. Feel free to give it a try.

madoar · 2018-10-21T12:34:28Z

phoenicis-dist/src/flatpak/org.phoenicis.javafx.appdata.xml

+    <p>Phoenicis ist ein Front-End für Wine.</p>
+  </description>
+  <categories>
+    <category>Game</category>


I'm not sure if Game is the correct category for Phoenicis.
Maybe something like Utility fits better.

madoar · 2018-10-21T12:35:26Z

phoenicis-dist/src/flatpak/org.phoenicis.javafx.appdata.xml

+    <p>Phoenicis is a front-end for Wine.</p>
+  </description>
+  <description xml:lang="de">
+    <p>Phoenicis ist ein Front-End für Wine.</p>


Are the translations manageable via Crowdin?

I don't think so (it's in the same file and not listed in their supported formats).

madoar · 2018-10-21T12:36:04Z

phoenicis-dist/src/flatpak/org.phoenicis.javafx.desktop

+Type=Application
+MimeType=application/x-ms-dos-executable;application/x-msi;application/x-ms-shortcut;
+Icon=org.phoenicis.javafx
+Categories=Game


Same as above

madoar · 2018-10-21T12:36:21Z

phoenicis-dist/src/flatpak/org.phoenicis.javafx.desktop

+MimeType=application/x-ms-dos-executable;application/x-msi;application/x-ms-shortcut;
+Icon=org.phoenicis.javafx
+Categories=Game
+Keywords=Phoenicis;


PlayOnLinux, Wine

I'm not sure how the keywords need to be split.
If they are split with a ;, the separator between PlayOnLinux and Wine is wrong.

madoar · 2018-10-21T12:37:24Z

phoenicis-dist/src/flatpak/org.phoenicis.javafx.json

+      ]
+    },
+    {
+      "name": "openjfx",


Is it still required to install OpenJFX separately?
Starting with Java 11 it should be possible to install JavaFX/OpenJFX via maven.

Doesn't work somehow. I get:

Error occurred during initialization of boot layer java.lang.module.FindException: Module javafx.controls not found

I think this indicates a problem with the java command and/or the project setup for Java 11.
Have you only removed the

{ "name": "openjfx", ... }

block?
Have you also removed the -p /app/javafx-sdk-11/lib argument to the java command?

The problem is: I have only JDK10 here (Ubuntu 18.04). If you check #1408, the maven dependencies do not seem to be enough (according to the tests of @ImperatorS79).

jjedelsky · 2018-10-27T10:09:33Z

phoenicis-dist/src/flatpak/org.phoenicis.javafx.json

+  "sdk-extensions": [
+    "org.freedesktop.Sdk.Extension.openjdk11"
+  ],
+  "add-extensions": {


I think there should be extension for 32bit libGL org.freedesktop.Platform.GL32. Without it, 32bit wine may be unable to use NVidia libGL.
See how steam flatpak adds 32bit extensions.

I've actually tried that but I always got an error when I tried to flatpak install this. Maybe I just did it wrong. Can you try?

madoar · 2018-11-06T11:19:30Z

@plata if this works as intended then I'm fine with merging this PR now.
Still I think we should at least open a new issue for the JavaFX 11 issue (i.e. an installed SDK is required, which looks like a bug/configuration problem to me) or fix it in this PR.

plata · 2018-11-15T18:44:28Z

I would like to merge this. The JavaFX issue is also there if you try to run Phoenicis built with JDK 11. I don't think it's related to Flatpak.

plata added 2 commits September 29, 2018 15:17

Add manifest

950d1f7

Add documentation

bfca4f1

plata and others added 3 commits September 29, 2018 17:16

Add required exports

aab93d3

Add new line at EOF

74078be

Fix java path

1abb8bb

Use sandbox

4653977

Use runtime 18.08

34c1316

plata mentioned this pull request Oct 13, 2018

Work with SELinux and/OR AppArmor to restrict access, #313

Closed

Merge branch 'master' into flatpak

e5aa831

plata added 2 commits October 20, 2018 13:12

Use OpenJDK 11

1e41568

Travis: build flatpak

55a177b

This was referenced Oct 20, 2018

Cannot run executable in flatpak sandbox flatpak/flatpak#2265

Closed

[Idea] Use Phoenicis CLI to install applications winepak/applications#146

Closed

plata added 2 commits October 21, 2018 12:54

Fix 32bit wine issue

34a398f

Use OpenJDK 11

4b97e26

Add meta data

0c552bf

Fix documentation

0e555c1

madoar reviewed Oct 21, 2018

View reviewed changes

plata added 3 commits October 21, 2018 14:41

Use category Utility

591bc3d

Add keywords

3640a46

Fix keywords

6c8c1fa

jjedelsky reviewed Oct 27, 2018

View reviewed changes

plata added 5 commits November 1, 2018 12:56

Add ld.so.conf

9715e49

Add .gitignore

00ba109

Describe required extensions

80e0827

Use "add-build-extensions"

36359c7

Use GL32

95db639

madoar approved these changes Nov 18, 2018

View reviewed changes

plata merged commit 4366454 into PhoenicisOrg:master Nov 19, 2018

plata deleted the flatpak branch November 19, 2018 17:53

Erick555 mentioned this pull request Dec 30, 2018

Add wine base app flathub/flathub#797

Closed

Add Flatpak support #1406

Add Flatpak support #1406

Conversation

plata commented Sep 29, 2018 • edited Loading

plata commented Sep 29, 2018

madoar commented Oct 5, 2018

plata commented Oct 5, 2018

madoar commented Oct 5, 2018

plata commented Oct 6, 2018

madoar commented Oct 7, 2018

plata commented Oct 7, 2018

Maryse47 commented Oct 8, 2018 • edited Loading

plata commented Oct 8, 2018

mbooth101 commented Oct 10, 2018

plata commented Oct 10, 2018

mbooth101 commented Oct 10, 2018

plata commented Oct 10, 2018

plata commented Oct 11, 2018

madoar commented Oct 11, 2018

plata commented Oct 12, 2018

plata commented Oct 12, 2018

madoar commented Oct 13, 2018

plata commented Oct 13, 2018

plata commented Oct 13, 2018

plata commented Oct 13, 2018

plata commented Oct 20, 2018

Maryse47 commented Oct 21, 2018

plata commented Oct 21, 2018

Maryse47 commented Oct 21, 2018

plata commented Oct 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madoar commented Nov 6, 2018

plata commented Nov 15, 2018

plata commented Sep 29, 2018 •

edited

Loading

Maryse47 commented Oct 8, 2018 •

edited

Loading