-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wine base app #797
Add wine base app #797
Conversation
de.ermshiperete.wine.BaseApp.yml
Outdated
branch: 4.0 | ||
|
||
runtime: org.freedesktop.Platform | ||
runtime-version: 1.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version is outdated. use 18.08
I'm not sure we want this here:
|
I would prefer plain wine flatpak or flatpak for wine wrapper like q4wine or POL. |
Perhaps the best solution would be to revive winepak or come up with a similar solution. |
I thought a base pack is for splitting an app into separately updatable packs.
This is a base pack for a specific app - see PR #798. Would it be better to rename this base pack to |
That makes even less sense, the entire point of baseapps is to share build time. |
258caf7
to
6619d77
Compare
@ermshiperete Use the Proton |
I agree that this is not a very good idea.
plata (POL developer) said:
https://www.playonlinux.com/en/topic-15675.html#m61438 However, we have a Steam client that features SteamPlay/Proton. See also: |
Flatpak for Phoenicis is already done but they won't submit it to flathub until Phoenicis itself leave the alfa stage. Using wine is much more than games (BTW: claims that you need some ancient wine versions to play them is a weird myth). I wouldn't want to wait till someone package |
The Lutris developer is interested in Flatpak but there is no ETA at all about that. |
PlayOnLinux is not only for games.
Regressions in WINE are a fact. That's why software like PlayOnLinux exists.
As @TingPing said:
This is not just about the version. Additional components (Microsoft Visual C++ Redistributable packages, codecs, fonts, DLLs, etc.) and settings (virtual desktop, CSMT, audio backend, Windows version, etc.) are very important too. Almost every major application should have its own virtual disk and registry. What's more, Flatpak is indented to run GUI apps, so pure WINE is not very suitable here. When it comes to WINE-based applications (bundled Win32 apps), I believe that snapcraft is a better place for them. They are already there. However, I wouldn't mind if TntConnect also appeared here. |
To be clear this isn't a technical difference, but one of policy where anything can be dumped on their store (because it has to be since there is only one store). |
Regression fixes are a fact too. In oftware like PlayOnLinux apps are kept with ancient wine versions because nobody touched their profile for the last 5 years.
You don't need flatpak to use wine prefixes. |
Sometimes it is true. Sometimes, however, you need a specific version of WINE to run the selected program/game (see common WINE postfixes in POL:
I didn't say anything like that. My point is that to get the best compatibility, you need to choose the right WINE version with the specified parameters and additional components. Then such a Flatpak/Snap bundle can make sense. |
Then whole text I quoted was completely irrelevant to this discussion.
I have latest wine in my distro default repos already. Flatpak has other benefits though. |
I don't think there is anything to add to what @TingPing has already said. We denied such requests in past and nothing has changed since then. Flatpak doesn't enforce a single store like Snap does, so it's perfectly possible to host separate repository, like it was the case with Winepak. |
I'm not necessarily against the base app itself though, however I'm afraid it will not receive enough attention to be kept up to date for multiple release branches. |
What is the point to have the BaseApp for WINE, when no app on Flathub will be able to use it? Even if it was allowed, how do you want to solve the problem that one application requires WINE in such version and the other one requires another variant? Do you suggest creating a branch for every possible version? I mean, we do not even have |
I already said how I want to solve it. The point of doing so is simple – there was idea in past to share build infrastructure with Winepak, we can very well just host the base apps ourselves.
I don't think you really know why it is so. Electron base apps were meant for repackaging binary releases, not builds from source code. |
As far as I know, they don't use their own BaseApp but the whole runtime - org.winepak.Sdk/org.winepak.Platform.
Just like here? :) I am afraid that this is impossible without See also: |
@ramcq Had a conversation with @winepak https://twitter.com/ramcq/status/1028206450995286016 |
Sure, because it makes more sense, which makes this PR even more moot if WInepak is going to be a thing again.
I think we all will appreciate if you finally quit trolling.
I know you like to show off your grep skills but it doesn't change the original intent. If it also deduplicates work for source-based builds, better for us. |
I think Winepak is pretty much dead currently. |
In regards of winepak, finding time to work on it has been my biggest issue. I have been working on the infrastructure and I do have an Ansible playbook to setup a better environment with buildbot. The buildbot-config has been giving me some issues. Haven't wanted to publish anything until it works right but I might just dump everything so other can help. Getting a working buildbot up and running is probably the best thing for winepak so others can push changes and update the repo. Right now every commit has to be approved, built, and pushed by me. Buildbot would automate that and allow other approved contributors to help. Would anyone on Flathub be able to help finish-up the buildbot-config? |
@julienrichen It feels very odd to me that we can't figure out a way to support Wine runtimes directly on Flathub infrastructure. It's a great candidate to deliver and demonstrate benefits of Flatpak providing a stable execution environment, and a useful tool for onboarding ISVs who have Windows software to port. Flathub-ists? What if we just add it to builds.json and off we go? We have other emulators, other downloaders, other not-third-party-blessed things, no? |
I have nothing against sharing build infrastructure I just didn't want the store to be filled with windows software. |
Indeed, virtually unsupportable Windows software is the problem, not Wine itself, |
@ramcq Sharing infrastructure would be even better, I would rather have someone more competent than me maintaining that aspect. I know we talked on Twitter about setting-up multiple repos. I believe you mentioned Flathub was interested in having a free & non-free software repo? I also agree with @TingPing @barthalion that wine software should be split off from Flathub. It could hurt Flathub's image since someone might download a currently working game and the devs of that game might make a change that wine doesn't handle yet. Now Flathub has broken software. It's even worst since we cannot compile the actual Windows software and see if it breaks before pushing :/ This is as oppose to users adding dl.winepak.org with the explicit understanding that stuff can become broken. I would be more than willing to point dl.winepak.org to a different winepak specific Flathub repo and even pay for a dedicate server for winepak builds. My other concerns is the amount usage we might consume. Most winepak apps are quick to build since they are just init scripts and a third-party downloader. One of the main goals of hosting a buildbot instance was to have the last 3 ~ 4 wine-staging SDKs rebuilding weekly with older versions being rebuild occasionally, mainly for security reasons to keep-up with changes in the fd.o SDK. Currently wine-staging has 22 releases, so for winepak that's 22 versions... on-top of the normal 3.0 & 4.0 release. Building SDKs can take a while and from my understanding most SDKs on Flathub are imported from the freedesktop, gnome, and kde repo right? The dedicate server for winepak should solve most of those issues but not sure what kind of changes would need to be made on Flathub's side to accommodate. Does Flathub have a repo just for infrastructure talk? Might be better to move this discussion to another thread. |
@julianrichen Create an account at Patreon for winepak |
@ramcq Has there been any internal discussion about multiple repos? |
@@ -0,0 +1,118 @@ | |||
id: de.ermshiperete.wine.BaseApp | |||
branch: 4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branch: 4.0 | |
branch: "4.0" |
Has been requested: |
No description provided.