Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the AdhocList and ExpandedList classes with MappedList and ConcatenatedList #1740

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Replace the AdhocList and ExpandedList classes with MappedList and ConcatenatedList #1740

merged 3 commits into from
Jan 14, 2019

Conversation

madoar
Copy link
Collaborator

@madoar madoar commented Jan 6, 2019

  • add ? extends to the inner generics of ConcatenatedList
  • change all usages of AdhocList to ConcatenatedList
  • change all usages of ExpandedList to a combination of MappedList and ConcatenatedList
  • remove the now unused AdhocList and AdhocListTest
  • remove the now unused ExpandedList and ExpandedListTest

@madoar
- add ? extends to the inner generics of ConcatenatedList
b0216e5 
- change all usages of AdhocList to ConcatenatedList
- change all usages of ExpandedList to a combination of MappedList and ConcatenatedList
- remove the now unused AdhocList and AdhocListTest
- remove the now unused ExpandedList and ExpandedListTest
@madoar
Merge branch 'master' into remove-adhoc-and-expanded-list
628d670
@madoar
Copy link
Collaborator Author

madoar commented Jan 6, 2019

@qparis, @plata please be sure to give this PR in-depth test, because I haven't used the ConcatenatedList before. It would be sad if its usage breaks something.

@plata
Copy link
Collaborator

plata commented Jan 8, 2019

What can we test? Sidebar buttons?

@madoar
Copy link
Collaborator Author

madoar commented Jan 9, 2019

Basically everything that has been changed by me:

  • all sidebars (also in combination with filters)
  • the content of the shown list widgets

plata
plata approved these changes Jan 12, 2019
View reviewed changes
Copy link
Collaborator

@plata plata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything looks good.

@madoar madoar merged commit 9d77087 into PhoenicisOrg:master Jan 14, 2019
@madoar madoar deleted the remove-adhoc-and-expanded-list branch January 14, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qparis qparis qparis approved these changes

@plata plata plata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madoar @plata @qparis