Skip to content

Commit

Permalink
use "x86" by default
Browse files Browse the repository at this point in the history
  • Loading branch information
@plata
plata committed Jan 9, 2017
1 parent 58d4e26 commit 141c5f8
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions Functions/Engines/Wine/script.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ Wine.prototype.prefix = function (prefix) {

this._prefixConfiguration.writeValue("wineDistribution", this._distribution);

var defaultArchitecture = Bean("architectureFetcher").fetchCurrentArchitecture().getNameForWinePackages();
this._architecture = this._prefixConfiguration.readValue("wineArchitecture", defaultArchitecture);
this._architecture = this._prefixConfiguration.readValue("wineArchitecture", "x86");

this._prefixConfiguration.writeValue("wineArchitecture", this._architecture);

Expand Down

3 comments on commit 141c5f8

@gverm
Copy link
Contributor

@gverm gverm commented on 141c5f8 Jan 10, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plata I think this introduced a regression. When I set .wineArchitecture("amd64") (tried x64 as well) it will still use x86.
EDIT: could be this commit as well: 58d4e26

@plata
Copy link
Collaborator Author

@plata plata commented on 141c5f8 Jan 11, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work with:

this._architecture = this._prefixConfiguration.readValue("wineArchitecture", this._architecture);

@gverm
Copy link
Contributor

@gverm gverm commented on 141c5f8 Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plata That does work indeed. I opened a PR with this fix, thanks!

Please sign in to comment.