Add Dreamscapes and Dreamscapes 2

[Starcommander]

Description

I added install scripts for 2 new Games

What works

Installing and playing on Linux and MacOs

What was not tested

I modified the scripts to match the new syntax from master branch.
That modification was not tested, i used Star_Craft2 as blueprint

Test

• Operating system:
  Debian10 and 11 via flatpak
  Mac Os X 10.13.6 via dmg package
• Hardware (GPU/CPU):
  On Debain11 I use a Radeon 5500 XT, that is not supported on flatpak --> software-rendering.

Ready for review

• Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
• json-align and eslint run according to the documentation.
• Codacy and travis checked.

[plata]

Please fix the Codacy issues and test the scripts before this can be merged.

[Starcommander]

@plata Hello! I fear, there is nothing wrong with the json file.
In my opinion this is a "false positive"
Can you give me any hint, what this "Codacy issues" are complaining about?

The syntax is the same as on "Star Craft 2".
And what is that message "Format error: unexpected "" "??

Thanks in advance.

[plata]

This is indeed very strange. I've never seen such a behavior before. I've contacted Codacy to clarify.

[plata]

This should be: https://github.com/codacy/codacy-meta/issues/415

[Zemogiter]

Shouldn't it be one application per PR?

[plata]

Would be better, yes.

[Starcommander]

Do I have to split it?
Or can you merge it at once?

[plata]

Normally one pull request per app. As the apps belong together, I would be ok with having an exception here. What's more important is that the scripts should be tested.

Apart from that: I've used this PR to test a work around for this strange Codacy behavior. Please merge upstream master to your fork such that the diff is shown correctly.

[Starcommander]

I am not able to test any upstream-script because of PhoenicisOrg/phoenicis#2230
Is this a bug?

[Starcommander]

@plata I was now able to test both scripts successfully.
Installs and runs with no issue.
But I had to change the freedesktop-version back as described in PhoenicisOrg/phoenicis#2230

[plata]

Shouldn't it be "Dreamscapes 2" (with space)?

[plata]

The URL is free-games-download: Is it free or not?

[Starcommander]

It is free of costs.
But it is not open source.
I will change it to true.
But I also suggest to distinguish between "free of cost" and free (regarding license).
So adding an additional field in future would be helpful, imho.

[plata]

Feel free to open a new issue to discuss this. Currently, it's free as in beer (see docs).

[plata]

See above

[Starcommander]

Personally I do not like spaces in file names and directories.
But it is your decision how it matches the rules of POL.
... in progress ...

[Starcommander]

Adding space and change preferences to free: done.
I also tested the script with "Dreamscapes 2" and it works.