-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dreamscapes and Dreamscapes 2 #1211
Conversation
Error on mac with corefonts: could not run cabextract
Please fix the Codacy issues and test the scripts before this can be merged. |
@plata Hello! I fear, there is nothing wrong with the json file. The syntax is the same as on "Star Craft 2". Thanks in advance. |
This is indeed very strange. I've never seen such a behavior before. I've contacted Codacy to clarify. |
This should be: https://github.com/codacy/codacy-meta/issues/415 |
Shouldn't it be one application per PR? |
Would be better, yes. |
Do I have to split it? |
Normally one pull request per app. As the apps belong together, I would be ok with having an exception here. What's more important is that the scripts should be tested. Apart from that: I've used this PR to test a work around for this strange Codacy behavior. Please merge upstream master to your fork such that the diff is shown correctly. |
I am not able to test any upstream-script because of PhoenicisOrg/phoenicis#2230 |
@plata I was now able to test both scripts successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be "Dreamscapes 2" (with space)?
"LINUX" | ||
], | ||
"testingOperatingSystems" : [], | ||
"free" : false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL is free-games-download
: Is it free or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is free of costs.
But it is not open source.
I will change it to true.
But I also suggest to distinguish between "free of cost" and free (regarding license).
So adding an additional field in future would be helpful, imho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to open a new issue to discuss this. Currently, it's free as in beer (see docs).
"LINUX" | ||
], | ||
"testingOperatingSystems" : [], | ||
"free" : false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
Personally I do not like spaces in file names and directories. |
Adding space and change preferences to free: done. |
Description
I added install scripts for 2 new Games
What works
Installing and playing on Linux and MacOs
What was not tested
I modified the scripts to match the new syntax from master branch.
That modification was not tested, i used Star_Craft2 as blueprint
Test
Debian10 and 11 via flatpak
Mac Os X 10.13.6 via dmg package
On Debain11 I use a Radeon 5500 XT, that is not supported on flatpak --> software-rendering.
Ready for review
json-align
andeslint
run according to the documentation.