Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Earth Eternal - Valkal's Shadow #463

Merged
merged 1 commit into from
Dec 11, 2017
Merged

added Earth Eternal - Valkal's Shadow #463

merged 1 commit into from
Dec 11, 2017

Conversation

rockfireredmoon
Copy link
Contributor

Earth Eternal - Valkal's Shadow is a fan-made and run server for the abandoned MMORPG 'Earth Eternal'. The game is totally free to download and play, you just need to sign up for an account at http://www.theanubianwar.com/user/register then use Request Key from your account page to create and link your game account. The game itself has worked flawlessly under wine for some time, as long as DirectX9 and Visual C++ runtime 2008 is installed.

Copy link
Collaborator

@plata plata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is your first submission, right? Good job!

@plata plata merged commit a915b6b into PhoenicisOrg:master Dec 11, 2017
"scriptName": "Online",
"compatibleOperatingSystems": ["LINUX"],
"testingOperatingSystems": [],
"free": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm a little late but shouldn't this be true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes it should. It is most definitely free. Do I need to do another pull request to correct this?

plata - yes this is my first for POL 5. I made a script for the same game when it was active for classic PlayOnLinux, but this was definitely a lot easier. I've got to say, I'm loving the new approach taken and it's nice to see JavaFX being used too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to fix this by opening a new PR.
It's nice to hear other people like the new PlayOnLinux application :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Must have missed that. Anyways, it's not a big deal and can be fixed in a small pull request like @madoar suggested.

Glad that you like the new approach to writing scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants