Documentation : Rework #811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug : PhoenicisOrg#792 Changes WINE environment from winxp to win7 -> winxp outputs error about unsupported OS. Changes executable to workaround PhoenicisOrg#792 Tested, working Signed-off-by: Jacob Hrbek <werifgx@gmail.com>
Commit on demand PhoenicisOrg#793 (comment)
Relevant : PhoenicisOrg#799 Created a concept of new documentation for README.md and CONTRIBUTION.md My abstract is to make `CONTRIBUTION.md` file with full instructions about contribution and summary of it in README.md with summary and introduction to a repository Added new file with contribution that should be used as full documentation for contributors, will also add images to make reading more effective. Looking for feedback Signed-off-by: Jacob Hrbek <werifgx@gmail.com>
This is a concept for new README.md, still work in progress Signed-off-by: Jacob Hrbek <werifgx@gmail.com>
|
Seems that you have removed Hearthstone files. We cannot merge |
|
@qparis i think i've removed them just from tracking, checking.. |
|
Based on informations from git on freenode it's correct, but i'm going to recreate it just to be sane. |
|
Requesting removal of #811, reason spam. |
Kreyren
pushed a commit
to Kreyrenicis/compatibilators
that referenced
this pull request
Mar 7, 2019
Removed vcrun2008, vcrun2017, corefonts, adobeair and dxd9 since dependencies for league of legends are stagend. Added hotfix for PhoenicisOrg#881 Signed-off-by: Jacob Hrbek <werifGX@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant : #799
Created a concept of new documentation for README.md and CONTRIBUTION.md
My abstract is to make
CONTRIBUTION.mdfile with full instructionsabout contribution and summary of it in README.md with summary and
introduction to a repository
Added new file with contribution that should be used as full
documentation for contributors, will also add images to make reading
more effective.
Looking for feedback