Update League Of Legends #797
Conversation
|
Error:
EDIT: Same issue on EUW Conclusion: Installers are updated by upstream. HOTFIX: Remove checksum (#797 (comment)) Permanent fix: Unknown |
|
Have you ran |
|
@Zemogiter No i didn't ? I also tried from git repo, but it complains about adobeair for some reason 🤔 Didn't investigate yet |
|
Please use the PR title template as described in the README. |
Kreyren
changed the title
|
@plata Sufficient? |
|
Remove Games/ and be more specific about what was changed. |
Kreyren
changed the title
|
@Zemogiter You sure it's good idea? Seems very insane.. |
|
@Kreyren yes because that's how everyone else including myself does |
|
@Zemogiter Noted, will add |
Kreyren
changed the title
|
Run |
|
Results in On
|
|
I got this error upon entering the download link in browser: |
Correct, it downloads installer from master it seems even when branch is defined on higger priority. Refferenced on PhoenicisOrg/phoenicis#1756 probably not relevant to the installer. |
|
Does the |
|
@madoar I does NOT, you can confirm on the commit. None of the other branches contains it to my knowledge.. trying to set it on highest priority |
|
@madoar those have commits from phoenicis? |
|
@Kreyren I don't understand? |
|
@madoar from https://github.com/KREY-PhoenicisOrg/scripts/tree/SMITE/Applications/Games/League%20of%20Legends/Online last commit to league of legends to SMITE is from phoenicis -> should be ignored by phoenicis assuming that it matches with master? |
|
If leagueoflegends branch is set on priority of 5 (higgest) the old installer is still pulled, restart wasn't performed only Trying priority of 1 |
|
Why should it be ignored? |
|
Set it to priority 5 (highest) and restart Phoenicis to ensure that all variables are set correctly. |
So that it would accept branches with commit for this usecase? Also should Set leagueoflegends on priority 5 and restarting -> old installer is still pulled? |
|
This error has nothing to do with the runtime. Is there something in the wine 4.7 folder ? If not, delete it so that it will download it again. |
|
I've fixed the D9VK include but it still crashes when trying to install directx9. |
Is noted, folder is not blank. kreyren@dreamon ~/GIT/KREYROCK $ ls ~/.Phoenicis/engines/wine/staging-linux-x86/4.7/
bin include lib shareit downloads it, but doesn't sees it. |
|
There is alternative patch for league of legends https://bugs.winehq.org/attachment.cgi?id=64507 |
|
@madoar How can I change the executable name based on some user intput ? My updated script currntly looks like this: const CustomInstallerScript = include("engines.wine.quick_script.custom_installer_script");
const {LATEST_STAGING_VERSION} = include("engines.wine.engine.versions");
const {fileName, mkdir, writeToFile} = include("utils.functions.filesystem.files");
const Resource = include("utils.functions.net.resource");
include("engines.wine.verbs.corefonts");
include("engines.wine.verbs.d9vk");
new CustomInstallerScript()
.name("League of Legends")
.editor("Riot Games")
.applicationHomepage("http://leagueoflegends.com/")
.author("Plata, feanor12, Thog, TheRuntimeIsNotWorkingRey, ImperatorS79, Zemogiter,")
.installationCommand(function (wizard) {
/// Select the region and download the setup file
const regions = ["EU West",
"Latin America North",
// "Latin America South", URL not found
"Oceania",
"Japan",
"Turkey",
"Brasil",
"EU Nordic & East",
"North America",
"Russia"];
const selectedRegion = wizard.menu(tr("Select your region:"), regions);
const baseUrl = "https://riotgamespatcher-a.akamaihd.net/releases/live/installer/deploy/League%20of%20Legends%20installer%20";
switch (selectedRegion.text){
case "EU West":
regionID = "EUW";
url = baseUrl+"EUW.exe";
break;
case "Japan":
regionID = "JP";
url = baseUrl+"JP.exe";
break;
case "Turkey":
regionID = "TR";
url = baseUrl+"TR.exe";
break;
case "Brasil":
regionID = "BR";
url = baseUrl+"BR.exe";
break;
case "EU Nordic & East":
regionID = "EUNE";
url = baseUrl+"EUNE.exe";
break;
case "North America":
regionID = "NA";
url = baseUrl+"NA.exe";
break;
case "Russia":
regionID = "RU";
url = baseUrl+"RU.exe";
break;
case "Oceania":
regionID = "OCE1";
url = baseUrl+"OCE1.exe";
break;
case "Latin America North":
regionID = "LA1";
url = baseUrl+"LA1.exe";
break;
}
var setupFile = new Resource()
.wizard(wizard)
.url(url)
.name(fileName(url))
.get();
return {command: setupFile};
})
.category("Games")
.executable("League of Legends installer " + regionID + ".exe")
.wineDistribution("staging")
.wineVersion(LATEST_STAGING_VERSION)
.preInstall(function (wine /*, wizard*/) {
wine.corefonts();
wine.D9VK();
});The problem is |
|
Are the League installers producing different executables depending on the region? I mean is just the downloaded installer named differently or also the final application executable "extracted" from the installer? |
|
The comment states the script uses d9vk but directx9 is used. |
|
The name of the installed exe depends on the region like the installer. |
|
I think it is currently not possible to pass a value from a previous step in the installation to a later one (i.e. from before the installation to the installation command or from before the installation hook to the after the installation hook). We will first need to add a method to do this, but I'm not sure how. One way would be to add an information "store" (i.e. a map) to the installer that can contain values (i.e. In addition we would need to change ...
.executable((store) => {
const regionId = store.regionId;
return `League of Legends installer ${regionId}.exe`
})
...I think we should discuss this in a new issue. |
|
Well, I could ask the region two times currently in order to fix the script ^^. |
|
Yes, but that wouldn't solve the issue that you can't access the regionId in |
|
I will delete .executable and create the shortcut "manually" |
|
@madoar installer is working now, so I assume this can be merged. |
|
Still getting the error from #797 (comment) |
|
What, I do not get this error at all. |
|
@ImperatorS79 have you tested only the installation or also the game itself? |
|
I did not test the game. Vulkan is not high enough on my machine to use D9VK. That is why I asked in the D9VK PR an option for linux user to skip that part top. |
| var regionID, url, sha1; | ||
| var baseUrl = "https://riotgamespatcher-a.akamaihd.net/ShellInstaller/"; | ||
| switch (selectedRegion.text) { | ||
| let url, regionID; |
There was a problem hiding this comment.
Move these directly over the switch statement where they are set
| switch (selectedRegion.text) { | ||
| let url, regionID; | ||
| /// Select the region and download the setup file | ||
| const regions = ["EU West", |
There was a problem hiding this comment.
For better readability:
const region = [
"EU West",
...
];| break; | ||
| case "Latin America North": | ||
| regionID = "LA1"; | ||
| url = baseUrl+"LA1.exe"; | ||
| break; | ||
| } | ||
| var setupFile = new Resource() |
There was a problem hiding this comment.
Add an empty line for readability purposes and const
| var batContent = "start C:\\LoL\\LeagueClient.exe"; | ||
| writeToFile(client, batContent); | ||
| wine.corefonts(); | ||
| wine.D9VK(); | ||
| }) |
|
MR abadoned, because @qparis is retard |
Status: Working untill June 2019, then broken compatibility (https://bugs.winehq.org/show_bug.cgi?id=46663) and roadblocked by phoenicis.
DESIGN
TODO
TODO: Add dgvoodo to allow DXVK
TODO: Add DXV9 to allow DXVK -> Depends on #932
CHANGELOG
Fixes: #777
Fixes: #778
Fixes: #870
Depends on: #790Depends on: #824Blocked by: PhoenicisOrg/phoenicis-winebuild#62
Affected by: #881
Added new sources for installers from riot games
BUG: Latin America South installer is missing
Updated SHA-1 for EUW, LAN, OCE, JP, TR, BR, EUNE, NA, RU
Set MACOSX in testing since it's not tested.
TODO : Performance can be improved beyond native, needs research
Expected the game to run on platinum.
pick 61ce52e Update script.js
pick 6fdf980 Update script.js
pick 41cec24 Pushed League Of Legends in testing
pick 6c05668 Update script.json
pick 6ee39fc Script optimization
pick 023059b Update script.js
pick ff0facc Update script.js
pick eb72429 Update script.js
pick f731ecb Update script.js
pick 5dd5058 Update script.js
pick 645418f Update script.js
pick 451850e Update script.js
ick 14c44c6 Remove space before ellipsis (#779)
pick 5867cf4 Update translations
pick f763592 Update JSDoc
pick 41733a1 README: add description how to use git clone as local repository (#780)
pick 89ced58 Improve the best practices for the creation of custom scripts (#781)
pick 1a21498 README: use a fork (#786)
pick 5aaa232 Update script.js
pick bf9092c Update script.js
pick 0d94012 Pushed League Of Legends in testing
pick d1b4db4 Update script.json
pick 3511278 Script optimization
pick e2b22e3 Update script.js
pick 78bb371 Update script.js
pick 68fc0b7 Update script.js
pick c00fd56 Update script.js
pick 5f11b7d Update script.js
pick 0b7a740 Update script.js
pick 5f5611d Update script.js
pick 6fdf980 Update script.js
pick 41cec24 Pushed League Of Legends in testing
pick 6c05668 Update script.json
pick 6ee39fc Script optimization
pick 023059b Update script.js
pick ff0facc Update script.js
pick eb72429 Update script.js
pick f731ecb Update script.js
pick 5dd5058 Update script.js
pick 645418f Update script.js
pick 451850e Update script.js
pick c0826a1 Games/League Of Legends : Update
pick 0818389 eh?
pick 4fa2d59 Hotfix : #797 (comment)
pick 59bac28 redo
pick b60d92d Update script.json
pick b3d2428 Games/LeagueOfLegends : Added more todos
pick f063e9f tried to remove irelevant parts?
pick 2f594d0 Update Wine LATEST_DEVELOPMENT_VERSION to 4.0-rc5 (#800)
pick d42fbb1 Update JSDoc
pick c530e59 Documentation: delete changelog (#794)
pick d5f53e5 script.js documentation: fix typo (#808)
pick d203e01 Add Adobeair (#801)
pick eb6e887 Update translations
pick ae8bbba Update Wine LATEST_DEVELOPMENT_VERSION to 4.0-rc6 (#807)
pick 938e8fd Update JSDoc
pick c853b8c Add Crowdin link to README (#809)
pick 58ce925 Update vulkanSDK (#742)
pick 27129bb Update JSDoc
pick 4f80934 Update README.md (#817)
pick ab2b30f Update AdobeAir
pick 22678fd Update JSDoc
pick 6f82923 Add: Mspaint
pick c912389 Update translations
pick ac12284 Update Wine LATEST_DEVELOPMENT_VERSION and LATEST_STAGING_VERSION to 4.0-rc7 (#833)
pick 01155f8 Update JSDoc
pick 6d0e481 Update DXVK (add new versions) (#837)
pick 3cbf976 Update JSDoc
pick 39ebf05 Update VK9 (#838)
pick 9148190 Update JSDoc
pick 8343f17 Add Faudio verb (#804)
pick 6aecdc7 Update translations
pick 79bfb5d Update JSDoc
pick 4f96383 Update Faudio verb (#845)
pick be90b20 Update JSDoc
pick 53598da Update to Wine 4.0 (#846)
pick dd3145f Update JSDoc
pick a67408c Add precision about windows dll's destination (#847)
pick 9b7c420 Update Adobe Acrobat Reader DC (fix dialogs) (#851)
pick 7dd61a0 Update Subnautica, using latest stable Wine version and added a postInstall warning regarding shader mods. (#850)
pick 5c501c4 Update translations
pick b839795 Add Subnautica Below Zero (#852)
pick b736a0f Update translations
pick 81473b2 Update DXVK and VK9 (precision about drivers) (#853)
pick 30d66ae Update translations
pick f7c7052 Update JSDoc
pick 6cdcc95 Update Hearthstone to fix shortcut creation error
pick 4890e6e Update Wine LATEST_DEVELOPMENT_VERSION and LATEST_STAGING_VERSION to 4.1 (#857)
pick 64231ec Update JSDoc
pick 83f48f3 Update Starcraft II (use latest stable Wine, fix executable name) (#861)
pick 0770124 Update osu!
pick 27c8d56 Update translations
pick 36048eb Udpate override_dll plugin: windows unset OS version will remove dll overides (#862)
pick 7054aa4 Update JSDoc
pick 43395a6 Update Wine.uninstall: return a boolean if the app has been uninstalled or not
pick d9c768b Revert update uninstall
pick 338e400 Update translations
pick 26ff20d Update JSDoc
pick cacdd44 Update Wine.uninstall: return a boolean
pick 03fdbcf Update translations
pick 6155f0a Update JSDoc
pick 5af4bf4 Update Wine LATEST_DEVELOPMENT_VERSION and LATEST_STAGING_VERSION to 4.2 (#868)
pick 4da43ee Update JSDoc
pick a6bbe8d Update Overwatch : multiple fixes
pick 8a03141 Include by ID (#865)
pick eb21277 Update JSDoc
pick 7a5412a Update vulkanSDK (#825)
pick 73a80af Update JSDoc
pick d278131 Update DXVK verb (new version) (#872)
pick eecb176 Update translations
pick b0d4a82 Update FAudio verb (new version) (#871)
pick 34d5820 Update translations
pick b4fd291 Update JSDoc
pick dbc073b Update dotnet (add versions +fix) (#839)
pick 096776a Update translations
pick 8dd1830 Update JSDoc
pick 9cb46f4 Update Elite: Dangerous, fix for #858 (#859)
pick fd528b9 Update DC Universe Online, removed Linux from testing operating systems (#873)
pick 6c9bb85 Add documentation about include mechanism (#856)
pick 84fbf26 Update script.js
pick 44a54e6 Update script.json
pick 9eb2e7d Games/LeagueOfLegends : Removed deps, hotfix for #811
pick db46d16 Games/LeagueOfLegends : Hotfix for #881
pick 32407ae trying to fix executable
pick fb331df Fixed the issue with .executable.. apparently
pick b6c23d7 d3dx9 verb is mandatory
pick 1ee07fe Update DXVK: auto install dlls (#874)
pick 7aadbc8 Update translations
pick c64e819 Update JSDoc
pick 47cc53d Update Wine LATEST_DEVELOPMENT_VERSION and LATEST_STAGING_VERSION to 4.3 (#878)
pick e8b0d5d Update JSDoc
pick 6b92ee6 Games/LeagueOfLegends : Pushed in testing (#876)
pick 1ee3f73 Update Space Colony, remove obsolete pre-install message (#882)
pick b0ff4a7 Update translations
pick 01f067b Update Local/Online Installer Script to handle args correctly (#883)
pick bdbf91c Update translations
pick 5e482a4 New Crowdin translations (#745)
pick 72397a7 Secure Wine.regedit().patch() (#887)
pick d217f1b Update JSDoc
pick cc66adf Use Java.type to access Java classes (#886)
pick 587fb76 Update translations
pick 7e1c000 Update JSDoc
pick 6b1f1d8 Wine.regedit().fetchValue(): ensure correct type for RegistryKey#getChild() (#888)
pick 93752af Update JSDoc
pick dd44dfc Fix shortcut creation (#890)
pick 0183976 Update JSDoc
pick eb58b42 Add Sprouts Adventure (#892)
pick aa91ee4 Update translations
Removed deps that are no longer required since they are staged in wine-staing.
Signed-off-by: Jacob Hrbek werifgx@gmail.com
IMPROVEMENTS
https://github.com/winepak/applications/blob/master/com.leagueoflegends.Client/com.leagueoflegends.Client.yml
Relevant
https://youtu.be/2sahzGzUznM
#932