Update Starcraft II (use latest stable Wine, fix executable name) #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImperatorS79
reviewed
Feb 9, 2019
ImperatorS79
approved these changes
Feb 9, 2019
plata
changed the title
|
@ImperatorS79 you can merge it when your comment has been implemented. Please use the updated title when merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here's the story:
An user form POL4 website was reporting the POL4 version of this script wasn't working due to broken link in flashplayer. I've told him to switch to POL5 since it have a more active support. Right after that I've checked if the script is still working. Right after the login screen appeared I get the "Starcraft2.exe not found" error. The script dosen't wait long enough so I did what @Kreyren did and changed it to Battle.net.exe
And while I was at it I've changed
wineVersionto use the latest stable Wine.