Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laser Repetition Rate to Setup group? #40

Open
smXplorer opened this issue Jul 18, 2017 · 2 comments
Open

Add Laser Repetition Rate to Setup group? #40

smXplorer opened this issue Jul 18, 2017 · 2 comments
Milestone

Comments

@smXplorer
Copy link
Contributor

We may want a way to store multiple laser repetition rates (although I don't know of an experiment where that would have been needed).
The setup group could be a better location than the photon_data group(s).

@tritemio tritemio added this to the 0.5 milestone Jul 18, 2017
@tritemio
Copy link
Contributor

tritemio commented Jul 18, 2017

Ok.

For a user saving nsALEX/PIE files nothing will change. Phconvert would be modified to save the repetition rate also in the setup group.

For user reading the files, they can take advantage on this field even for non standard measurements.

The new field can be made mandatory only for measurements that have at least one pulsed laser:

Proposal

/setup/laser_repetition_rates (array of floats): repetition rate in Hz for each laser. If a laser is CW, its repetition rate is conventionally 0. Similarly to other laser-specific fields, lasers are ordered according to increasing wavelength.

@tritemio
Copy link
Contributor

tritemio commented Aug 28, 2017

  • Add /setup/laser_repetition_rate to the documentation
  • Add /setup/laser_repetition_rate support to phconvert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants