Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement star selector #181

Merged
merged 2 commits into from Aug 17, 2022
Merged

Implement star selector #181

merged 2 commits into from Aug 17, 2022

Conversation

Alkarex
Copy link
Contributor

@Alkarex Alkarex commented Aug 17, 2022

Add support for selectors such as a[href*="example"]
https://developer.mozilla.org/docs/Web/CSS/Attribute_selectors
Translated to .//a[contains(@href,"example")]

Add support for selectors such as `a[href*="example"]` https://developer.mozilla.org/docs/Web/CSS/Attribute_selectors
Translated to `.//a[contains(@href,"example")]`
@Alkarex Alkarex mentioned this pull request Aug 17, 2022
Alkarex added a commit to Alkarex/CssXPath that referenced this pull request Aug 17, 2022
Add default linting rules for Markdown https://github.com/DavidAnson/markdownlint

I met a bunch of warnings in my editor (VSCode) when opening the project to work on PhpGt#181
This PR fixes them for Markdown, also with some rules for Markdownlint, one of the most common linters for this language
Alkarex added a commit to Alkarex/CssXPath that referenced this pull request Aug 17, 2022
Add default linting rules for Markdown https://github.com/DavidAnson/markdownlint

I met a bunch of warnings in my editor (VSCode) when opening the project to work on PhpGt#181
This PR fixes them for Markdown, also with some rules for Markdownlint, one of the most common linters for this language
@Alkarex Alkarex mentioned this pull request Aug 17, 2022
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Aug 17, 2022
Add support for selectors such as `a[href*="example"]`
https://developer.mozilla.org/docs/Web/CSS/Attribute_selectors
Translated to `.//a[contains(@href,"example")]`

Upstream PR: PhpGt/CssXPath#181
@g105b
Copy link
Member

g105b commented Aug 17, 2022

This looks great, thank you. I'll get it merged as soon as I've taken a deeper look into it.

@g105b g105b added this to WIP in Overview Aug 17, 2022
@g105b g105b merged commit 886c420 into PhpGt:master Aug 17, 2022
Overview automation moved this from WIP to Done August 2022 Aug 17, 2022
@g105b
Copy link
Member

g105b commented Aug 17, 2022

Love it, thank you!

g105b added a commit that referenced this pull request Aug 17, 2022
Add default linting rules for Markdown https://github.com/DavidAnson/markdownlint

I met a bunch of warnings in my editor (VSCode) when opening the project to work on #181
This PR fixes them for Markdown, also with some rules for Markdownlint, one of the most common linters for this language

Co-authored-by: Greg Bowler <greg.bowler@g105b.com>
@Alkarex Alkarex deleted the star-selector branch August 17, 2022 19:57
Alkarex added a commit to FreshRSS/FreshRSS that referenced this pull request Aug 18, 2022
* CssXPath-StarSelector
Add support for selectors such as `a[href*="example"]`
https://developer.mozilla.org/docs/Web/CSS/Attribute_selectors
Translated to `.//a[contains(@href,"example")]`

Upstream PR: PhpGt/CssXPath#181

* Upstream merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Overview
Done August 2022
Development

Successfully merging this pull request may close these issues.

None yet

2 participants