We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typical fetch:
$http->fetch("http://example.com") ->then(function(Response $response) { if(!$response->ok) { return; // HERE LIES AN ISSUE } return $response->text(); }) ->then(function(string $html) { // ... });
Because the next promise in the chain expects a string of html, it's impossible to return nothing.
What's the proper way of returning early? Should we be able to return void at this point?
The text was updated successfully, but these errors were encountered:
test: pass existing tests for #70 functionality
c1a49be
Chained promise returning (#71)
0bdb4d7
* test: pass existing tests for #70 functionality * build: php 8.1 compatibility * ci: use latest phpunit * ci: use latest phpunit * ci: debug phpunit * ci: debug phpunit * ci: debug phpunit * test: ensure "finally" can return its own promise * test: ensure "finally" can return its own promise * test: fix static analysis * build: ignore complexity error
test: add tests that close #52 after #70's implementation
0dc14b6
test: add tests that close #52 after #70's implementation (#72)
ac75701
Successfully merging a pull request may close this issue.
Typical fetch:
Because the next promise in the chain expects a string of html, it's impossible to return nothing.
What's the proper way of returning early? Should we be able to return void at this point?
The text was updated successfully, but these errors were encountered: