Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index takes preference over @dynamic page files #320

Closed
g105b opened this issue Jul 13, 2019 · 3 comments
Closed

Index takes preference over @dynamic page files #320

g105b opened this issue Jul 13, 2019 · 3 comments
Labels
Milestone

Comments

@g105b
Copy link
Member

g105b commented Jul 13, 2019

Quite a self explanatory bug; if there is a file at page/dir/index.html, the dynamic file at page/dir/@page.html does not load when viewing uri /dir/something, instead it loads the index file still.

This is because the basename returned by

$basePath = $this->getBaseViewLogicPath();
does not take into account the @ prefixed files.

@g105b g105b added the bug label Jul 13, 2019
@g105b g105b added this to the v3 milestone Jul 23, 2019
@g105b g105b closed this as completed in 58f23b9 Jul 23, 2019
@g105b
Copy link
Member Author

g105b commented Jul 23, 2019

🎉

@g105b g105b reopened this Jul 25, 2019
@g105b
Copy link
Member Author

g105b commented Jul 25, 2019

Reopening until tests written

@g105b
Copy link
Member Author

g105b commented Jul 26, 2019

There is a new bug now this is fixed: anything that doesn't match a routable URI is now handled by index. So localhost/anything will become a dynamic version of localhost/index.

g105b added a commit that referenced this issue Jul 30, 2019
@g105b g105b closed this as completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant