Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scsictl shall accept generic key/value pairs for options that take parameters #1240

Closed
uweseimet opened this issue Oct 7, 2023 · 1 comment · Fixed by #1274
Closed

scsictl shall accept generic key/value pairs for options that take parameters #1240

uweseimet opened this issue Oct 7, 2023 · 1 comment · Fixed by #1274
Assignees
Labels
enhancement New feature or request

Comments

@uweseimet
Copy link
Contributor

uweseimet commented Oct 7, 2023

Some scsictl options expect more than one parameters for some options, e.g. the options for copying/renaming files. With #1238 there are up to three parameters. The current syntax for such a case expects the parameters in a particular order, separated by a colon. keys are implicit, only the values are specified. If only the third parameter is needed the parameter list has to start with two colons in order to pass the empty parameters, e.g.

>scsictl -s::mapping_info

Sometimes it may be simpler to just pass all possible parameters as key value pairs and in any order, e.g.

>scsictl -soperations=mapping_info:folder_pattern=pattern

In order to support both styles, when there is an equals ('=') character in the parameter list scsictl shall assume that the key/value format is used and parse the parameter list accordlingly.

@uweseimet uweseimet added the enhancement New feature or request label Oct 7, 2023
@uweseimet uweseimet self-assigned this Oct 7, 2023
@uweseimet uweseimet moved this from To Do to In Progress in Release 23.11.01 (first Bookworm release) Oct 7, 2023
uweseimet added a commit that referenced this issue Oct 7, 2023
@uweseimet
Copy link
Contributor Author

>scsictl -soperations=mapping_info
Supported image file extension to device type mappings:
  hd1->SCHD
  hda->SCHD
  hdi->SCHD
  hdn->SCHD
  hdr->SCRM
  hds->SCHD
  is1->SCCD
  iso->SCCD
  mos->SCMO
  nhd->SCHD

uweseimet added a commit that referenced this issue Oct 31, 2023
…rameters (#1240) (#1274)

* scsictl accepts generic key/value pairs for options that take parameters
@uweseimet uweseimet moved this from In Progress to Done in Release 23.11.01 (first Bookworm release) Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant