Fix Parameter Descriptor Incorrectly Populating Range Constraints for size_lt and size_gt #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the string checking in the declare(_runtime)_parameters templates,
size_lt
andsize_gt
would incorrectly populate the descriptor range constraints since it also has 1 argument. This changes that line in the template to explicitly check forlt
,lt_eq
,gt
, andgt_eq
so that we avoid this error and hopefully other errors in the future.Not the cleanest implementation, but added a function_base_name without the template brackets
<>
. This passes the checks I've looked for and should reduce the descriptors being inadvertently filled unless the validation function name has both the substringlesser
/greater
andbounds
in it with 1 argument. Could clean up in future if desired but would need to think about how to structure this in the jinja templates / main.py, as it's a bit long. But this should work without any false positives now.