fixup SFINAE detection of boilerplate API #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version sadly defaulted to the second branch and simply spun until shutdown without calling run(). This bit of `void_t` based partial instantiation implements the proper check.
|
Ping @mlautman @JafarAbdi . |
JafarAbdi
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup for #4 .
The previous version sadly defaulted to the second branch and simply spun until shutdown without calling run(). I only noticed this just now, sorry.
This bit of
void_tbased partial instantiation implements the proper check.I learned quite a bit about SFINAE looking for short proper solutions to this.
@mlautman @JafarAbdi