WIP: Clang tidy fixes #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davetcoleman
reviewed
Jun 4, 2020
| @@ -1,66 +0,0 @@ | |||
| --- | |||
| @@ -84,7 +84,7 @@ static const double SMALL_SCALE = 0.001; | |||
| static const double LARGE_SCALE = 100; | |||
|
|
|||
| // Note: when adding new colors to colors, also add them to getRandColor() function | |||
| enum colors | |||
| enum Colors | |||
There was a problem hiding this comment.
I think this will break a lot of existing code, are we sure its necessary?
| <name>rviz_visual_tools</name> | ||
| <version>3.7.0</version> | ||
| <description>Utility functions for displaying and debugging data in Rviz via published markers</description> | ||
|
|
||
| <maintainer email="mike@picknik.ai">Mike Lautman</maintainer> | ||
| <author email="mike@picknik.ai">Mike Lautman</author> |
There was a problem hiding this comment.
@mlautman I'm not sure why I was removed as an author, I wrote most of this package myself in grad school.
Suggested change
| <author email="mike@picknik.ai">Mike Lautman</author> | |
| <author email="dave@picknik.ai">Dave Coleman</author> | |
| <author email="mike@picknik.ai">Mike Lautman</author> |
| @@ -1,22 +1,20 @@ | |||
| <?xml version="1.0"?> | |||
| <package format="2"> | |||
| <package format="3"> | |||
| <name>rviz_visual_tools</name> | |||
| <version>3.7.0</version> | |||
| <description>Utility functions for displaying and debugging data in Rviz via published markers</description> | |||
|
|
|||
| <maintainer email="mike@picknik.ai">Mike Lautman</maintainer> | |||
There was a problem hiding this comment.
@nbbrooks should you be listed as maintainer also? You seem to be doing a lot on this package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.