Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifold Cloud Agent UX error #195

Open
b1conrad opened this issue Sep 2, 2021 · 1 comment
Open

Manifold Cloud Agent UX error #195

b1conrad opened this issue Sep 2, 2021 · 1 comment
Labels

Comments

@b1conrad
Copy link
Member

b1conrad commented Sep 2, 2021

When a connection is created, but is incomplete because it lacks their_endpoint, the UI will just hang. There will be an error in the browser console, but most people wouldn't see that, and there is no workaround. The thing containing this app and an incomplete connection will be unusable for this app. Other apps would still be okay.

See this issue (in the Manifold-production-instance repo) for full analysis.

The request here is that the React code be made more robust. The connection should still show, but the Messaging tab should be disabled (since it is useless without the endPoint anyway).

@b1conrad b1conrad added bug help wanted ui user experience labels Sep 2, 2021
@b1conrad
Copy link
Member Author

b1conrad commented Sep 2, 2021

The actual problem is the concat function used with the "invitation" which might be undefined.

Consider why the id is constructed in this way, and simplify if possible. If desired to retain it, consider using + for string concatenation instead of concat. See the "Performance" paragraph in this doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant