Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional blinkage #75

Merged
merged 1 commit into from
Apr 3, 2023
Merged

optional blinkage #75

merged 1 commit into from
Apr 3, 2023

Conversation

PietroPasotti
Copy link
Collaborator

@PietroPasotti PietroPasotti commented Mar 31, 2023 •
edited
Loading

Jhack nuke's blink animation is now configurable and defaults to false.
Fixes #74

@PietroPasotti PietroPasotti mentioned this pull request Mar 31, 2023
Closed
carlcsaposs-canonical
carlcsaposs-canonical approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via pipx install git+https://github.com/PietroPasotti/jhack.git@conf-blinkage (didn't test enabling blink in config)

@PietroPasotti PietroPasotti merged commit 1078304 into master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlcsaposs-canonical carlcsaposs-canonical carlcsaposs-canonical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to disable blinking animation in jhack nuke
2 participants
@PietroPasotti @carlcsaposs-canonical