Fix #1422710, 1422715 - Fix use of Recolor tool after use of Editable sh... #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shape. The issue is that Recolor temporarily draws on the ToolLayer, which it expects to be invisible. Editable shapes make the ToolLayer visible when activated but never hides it, so the Recolor tool's temporary works is visible. Fix by hiding the tool layer when an editable tool finalized all its shapes. Doing it on tool deactivation misses a case where you switch to a new image and then change the tool.
|
If I do Recolor -> Line/Curve -> Recolor, and then undo 3 times, the last Recolor operation appears again. Maybe the Recolor tool needs to clear out the ToolLayer when it's done with it? |
|
I think any user of the ToolLayer is supposed to manage its own usage of it, which is:
So I think the proper way to do this is the Editable shapes tool needs to clear it when it wants to turn it on. (Or else we will just hit this again if a 3rd party Add-In tool leaves work on the ToolLayer.) |
|
Fixed the edit engine to always clear the ToolLayer before using it. |
…by the edit engine, because it might have been changed by another tool. Fortunately Clear should be a relatively cheap operation.
cameronwhite
added a commit
that referenced
this pull request
Feb 19, 2015
Fix #1422710, 1422715 - Fix use of Recolor tool after use of Editable sh...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ape.
The issue is that Recolor temporarily draws on the ToolLayer, which it expects to be invisible. Editable shapes make the ToolLayer visible when activated but never hides it, so the Recolor tool's temporary work is visible. Fix by hiding the tool layer when an editable tool finalized all its shapes. Doing it on tool deactivation misses a case where you switch to a new image and then change the tool.