Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1422710, 1422715 - Fix use of Recolor tool after use of Editable sh... #88

Merged
merged 2 commits into from
Feb 19, 2015
Merged

Fix #1422710, 1422715 - Fix use of Recolor tool after use of Editable sh... #88

merged 2 commits into from
Feb 19, 2015

Commits on Feb 18, 2015

  1. Fix #1422710, 1422715 - Fix use of Recolor tool after use of Editable… 

    … shape.

The issue is that Recolor temporarily draws on the ToolLayer, which it expects to be invisible.  Editable shapes make the ToolLayer visible when activated but never hides it, so the Recolor tool's temporary works is visible.  Fix by hiding the tool layer when an editable tool finalized all its shapes.  Doing it on tool deactivation misses a case where you switch to a new image and then change the tool.
    @jpobst
    jpobst committed Feb 18, 2015
    Configuration menu
    Copy the full SHA
    1b10700 View commit details
    Browse the repository at this point in the history

  2. Remove optimization to only clear ToolLayer when it has been changed … 

    …by the edit engine, because it might have been changed by another tool. Fortunately Clear should be a relatively cheap operation.
    @jpobst
    jpobst committed Feb 18, 2015
    Configuration menu
    Copy the full SHA
    eab9467 View commit details
    Browse the repository at this point in the history