Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docking #92

Merged
merged 7 commits into from Mar 5, 2015
Merged

Update docking #92

merged 7 commits into from Mar 5, 2015

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Mar 3, 2015

This is the first step of pulling in the latest docking library from MonoDevelop. This is simply the updated bits for the parts we use today, it does not include any new features yet.

It also moves all the code to a separate library to help keep it isolated.

I tested it on Windows and Mac, it has not been tested on Linux.

…d as a diff to the final files as a history of changes we made from upstream.
…p's docking library compiling and working.

Note that this is an intermediate step that brings in an XWT dependency that will need to be eliminated.
@cameronwhite
Copy link
Member

I'll give it a test on Linux before merging, but I think there will probably need to be an update to the Makefile to include Pinta.Docking in the list of dlls

@cameronwhite
Copy link
Member

I did some brief testing and it seems to work okay on Linux. The only issue I noticed was that the auto-hide and close buttons don't highlight when the mouse hovers over them. I haven't tested the docking changes on Windows so I don't know if that's platform-specific or not.

@jpobst
Copy link
Contributor Author

jpobst commented Mar 4, 2015

Doesn't highlight on Windows either, so it must be a change to the library. They are definitely new icons.

@jpobst
Copy link
Contributor Author

jpobst commented Mar 4, 2015

Never mind, I found a method I had just stubbed out that fixes this.

@cameronwhite
Copy link
Member

OK, thanks. Could you look at fixing the errors on the Travis CI build? I think the SetSource extension method that I added to CairoExtensions.cs might be need there as well.

@jpobst
Copy link
Contributor Author

jpobst commented Mar 5, 2015

Looks like that was it, thanks for the tip!

cameronwhite added a commit that referenced this pull request Mar 5, 2015
Update the docking library from MonoDevelop.
@cameronwhite cameronwhite merged commit 36ee564 into PintaProject:master Mar 5, 2015
@jpobst jpobst deleted the update-docking branch March 5, 2015 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants