Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] HTTP triggers - add Match path requests prop to filter requests #11917

Open
vunguyenhung opened this issue May 10, 2024 · 1 comment
Labels
enhancement New feature or request triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@vunguyenhung
Copy link
Collaborator

vunguyenhung commented May 10, 2024

Is your feature request related to a problem? Please describe.
Some users faced an issue that their HTTP endpoint is called by crawlers for robot.txt
https://pipedream-users.slack.com/archives/CPTJYRY5A/p1715325204478109

Describe the solution you'd like
Add Match Path prop to HTTP triggers so they will only emit events for path that matched the specified path

Do you have a workaround?
Filter actions

@vunguyenhung vunguyenhung added the enhancement New feature or request label May 10, 2024
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label May 10, 2024
@vunguyenhung vunguyenhung changed the title [FEATURE] HTTP triggers - add Ignore Robot.txt requests prop [FEATURE] HTTP triggers - add Match path requests prop to filter requests May 10, 2024
@mroy-seedbox
Copy link
Contributor

mroy-seedbox commented May 11, 2024

Ideally, this parameter should take in a list of regexes to match against, so that we can accept multiple paths.

Otherwise, even a single regex can allow us to enter multiple options, like this: (path1)|(path2)|(path3)|.... But I think an array would be more user friendly.

For example, we have HTTP triggers to which we add a Slack channel ID in the path. We should be able to use a regex in order to match against the Slack channel ID format (or even a list of known IDs from an env var), and filter out anything else.

Optional/bonus: also allow to filter based on the HTTP method (in a separate prop, of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged For maintainers: This issue has been triaged by a Pipedream employee
Development

No branches or pull requests

4 participants