Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Newtonsoft #1901

Closed
tidyui opened this issue Jul 12, 2022 · 3 comments
Closed

Upgrade Newtonsoft #1901

tidyui opened this issue Jul 12, 2022 · 3 comments
Assignees
@tidyui
Labels
core enhancement
Milestone
Version 10.2

Comments

@tidyui
Copy link
Member

tidyui commented Jul 12, 2022

Upgrade to latest version.
@Neutrino-Sunset
Copy link

Is Newtonsoft still needed? Does it do anything that can't be done with System.Text.Json?

@tidyui
Copy link
Member Author

tidyui commented Jul 25, 2022

The JSON serialization/deserialization relies on polymorphism which is supported OTB by Newtonsoft by would require a lot of custom stuff in System.Text.Json

@tidyui tidyui added this to the Version 11.0 milestone Aug 2, 2022
@tidyui tidyui self-assigned this Aug 2, 2022
@tidyui
Copy link
Member Author

tidyui commented Aug 2, 2022

Fixed in version 10.0.0

@tidyui tidyui closed this as completed Aug 2, 2022
@tidyui tidyui modified the milestones: Version 11.0, Version 10.2 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tidyui tidyui

Labels
core enhancement
Projects
No open projects
Version 10.2
Status: Done
Milestone
Version 10.2
Development

No branches or pull requests
2 participants
@tidyui @Neutrino-Sunset