Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ImageSharp to support wepb #1935

Closed
NilssonMalin opened this issue Sep 23, 2022 · 4 comments
Closed

Upgrade ImageSharp to support wepb #1935

NilssonMalin opened this issue Sep 23, 2022 · 4 comments
Assignees
Milestone

Comments

@NilssonMalin
Copy link

ImageSharp support webp since v2.
"What's new since V1 #
Some major features!
WebP support - People have been after this for a while! We provide comprehensive support for decoding and encoding WebP images."

Piranha is on ImageSharp 1.0.4 at the moment.

@NilssonMalin
Copy link
Author

Hi @tidyui, can I contribute and do this myself?

@tidyui
Copy link
Member

tidyui commented Sep 26, 2022

@NilssonMalin Absolutely, just send a PR with the changes! However as it is a major version upgrade of a dependency it will probably not be released until the next major is released.

We’re dragging a bit behind, so we will most likely cut things out of the next release, but if you need the support quickly you can build your own ImageSharp package from source code and use. I recommend creating a local alpha version so you don’t run into issues when the official version is released.

Regards

@tidyui tidyui added this to the Version 11.0 milestone Sep 26, 2022
@NilssonMalin
Copy link
Author

@tidyui do you have a timeplan or at least a guess on when we can count on having the next major released?

@tidyui
Copy link
Member

tidyui commented Sep 28, 2022

@NilssonMalin Moved this fix into 10.2 which will be released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants