Logging config overwritten

[Fruchtzwerg94]

python-websocket-server/websocket_server/websocket_server.py

Line 18 in fd0b190

logging.basicConfig()

overwrites an already set logging configuration if the module is imported afterwards. Whats the reason of this line of code here?

[ramezanifar]

To @Pithikos
I would like to thank you for this wonderful module. It is super easy to use. Really good job.
I also recommend allowing to pass a logger handle as an argument to the class for a custom configuration instead of logging.basicConfig().

To @Fruchtzwerg94
For me, it does not overwrite a custom configuration but it prints a message twice. To solve that issue I used:
logger.propagate = False

This is a simple sample :

import logging
from websocket_server import WebsocketServer

def new_client(client, server):
	server.send_message_to_all("Hey all, a new client has joined us")

#------------------------------------------------------------
# A custom logger
logger = logging.getLogger('my_custom_logger')
ch = logging.StreamHandler()
formatter = logging.Formatter('%(asctime)s - %(levelname)s - %(message)s')
ch.setFormatter(formatter)
logger.addHandler(ch)
logger.setLevel(logging.INFO)
logger.propagate = False  # Without this, the next message will be printed twice
#------------------------------------------------------------
logger.info("Ready to start the server")

server = WebsocketServer(13254, host='127.0.0.1', loglevel=logging.INFO)
server.set_fn_new_client(new_client)
server.run_forever()

[tysonite]

Yeah. Agree, nice module/library. It would be nice to fix global logging, though. Hopefully, someone can provide PR...