FIxed invalid timecode frame number error message #795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Fixed issue where invalid timecode rate error message would always say
has frames beyond 0.000000
rather than the correct maximum frame number.This error tends to come up a lot when an incorrect rate is specified when parsing a CMX edl.
Reference associated tests.
Added a unittest to both ensure the
ValueError
is raised in this case and the helpful message is correctly generated.