Add Try/Except around imporlib.reload for unit test to run in python2.7 as well as 3.4+ #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_plugin_detection test was failing for me in python 2.7 due to a missing
importlib.reload()
. I believe this is only available in python 3.4+.This change lets the test fall back to
imp.reload()
in cases where it can't find theimportlib
one.There is a related question about how the 2.7 tests did not detect this which I think is related to a missing
mock
module. I'll follow up offline about that.