-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace boost hash usage with TfHash in pxr/usd/usd #2187
Conversation
@nvmkuruc , it looks like all the dependent/upstream files got pulled in, indavertently? |
I asked Nick about this and he said that it should be fine and resolve itself as the upstream dependency branches got pulled in, and I should just note in the pull request what the PR was dependent on. If there's a better way to have organized the stacking of PRs to avoid this, happy to reorganize. |
I think I can take a pass at making most of these PRs dependent on just the |
All the pull requests have been updated to be dependent on only either dev or the tfhash pull request. |
Awesome - thanks, Matt!
…--spiff
On Mon, Jan 23, 2023 at 12:43 PM nvmkuruc ***@***.***> wrote:
I think I can take a pass at making most of these PRs dependent on just
the pxr/base/tf changes which should hopefully make these easier to look
at.
All the pull requests have been updated to be dependent on only either dev
or the tfhash pull request.
—
Reply to this email directly, view it on GitHub
<#2187 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPOU2CFVNGMEMKJHUVVLATWT3UOFANCNFSM6AAAAAAUCESUO4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
58e514b
to
0baaa36
Compare
Filed as internal issue #USD-7907 |
7ad3aed
to
60da749
Compare
15ecd8d
to
8e7341a
Compare
Description of Change(s)
Requires #2173
To remove the dependency of pxr/usd/usd on boost's hashing functions
boost::hash_combine
is replaced withTfHash::Combine
, delegating hashing of containers instead of iteratingboost::hash
is replaced withTfHash
UsdStageLoadRules
,UsdObject
derived classes, andUsdCollectionMembershipQuery
.Fixes Issue(s)
-#2172 (additional PRs forthcoming)